Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug waitForResult integration test #2773

Open
maschad opened this issue Jul 15, 2024 · 2 comments
Open

Debug waitForResult integration test #2773

maschad opened this issue Jul 15, 2024 · 2 comments
Labels
chore Issue is a chore

Comments

@maschad
Copy link
Member

maschad commented Jul 15, 2024

We should ensure waitForResult always waits for the transaction to be processed to ensure that our subscriptions remain valid even if keep-alive messages change.

The current integration test for this doesn't work.
@maschad maschad added bug Issue is a bug chore Issue is a chore labels Jul 15, 2024
@maschad maschad added this to the 0.x mainnet milestone Jul 15, 2024
@maschad maschad mentioned this issue Jul 15, 2024
Merged
4 tasks
@arboleya arboleya added the p0 label Jul 15, 2024
@mvares mvares mentioned this issue Jul 16, 2024
Closed
4 tasks
@maschad maschad self-assigned this Jul 17, 2024
@arboleya arboleya removed this from the 0.x mainnet milestone Jul 19, 2024
@maschad maschad added p2 and removed bug Issue is a bug p0 labels Jul 22, 2024
@maschad maschad removed their assignment Jul 22, 2024
@arboleya arboleya removed the p2 label Aug 2, 2024
@Torres-ssf
Copy link
Contributor

@maschad Was this failing only on the CI or also locally?

@maschad
Copy link
Member Author

maschad commented Aug 6, 2024

@Torres-ssf It is currently failing for me locally on master

@arboleya arboleya added temp-p2 and removed temp-M labels Sep 7, 2024
@arboleya arboleya added the temp:notion label Sep 8, 2024 — with Linear
@arboleya arboleya added the temp-linear label Sep 8, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove skip from the waitForResult test mvares/fuels-ts
3 participants
@arboleya @maschad @Torres-ssf