Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the ABI Coder package #1795

Closed
danielbate opened this issue Feb 23, 2024 · 3 comments
Closed

Refactor the ABI Coder package #1795

danielbate opened this issue Feb 23, 2024 · 3 comments
Assignees
Labels
feat Issue is a feature

Comments

@danielbate
Copy link
Contributor

danielbate commented Feb 23, 2024

This issue should act as the epic with other issues spun off from here.

The goals of this refactor are to:

@danielbate danielbate added blocked chore Issue is a chore labels Feb 23, 2024
@danielbate danielbate changed the title Refactor and improve the ABI Coder Refactor and improve the ABI Coder package Feb 23, 2024
@petertonysmith94
Copy link
Contributor

Note: the following field paths on the JsonAbi are not present on the json-abi-format specification

functions.output.name
loggedTypes.loggedType.name
configurables.configurableType.name

@danielbate danielbate removed the blocked label Jun 3, 2024
@danielbate danielbate changed the title Refactor and improve the ABI Coder package Refactor the ABI Coder package Jun 7, 2024
@danielbate danielbate added epic and removed chore Issue is a chore labels Jun 7, 2024
@arboleya arboleya added this to the 1. caterpillar milestone Jun 9, 2024
@arboleya arboleya added p0 chore Issue is a chore and removed epic labels Jun 9, 2024
@nedsalk
Copy link
Contributor

nedsalk commented Jun 17, 2024

If changes happen to coders so that they don't return the offset value anymore, we should also update the Interface.decodeLog and Interface.decodeFunctionResult methods accordingly. See #2514 and the comments on it.

@arboleya arboleya added feat Issue is a feature and removed chore Issue is a chore labels Aug 1, 2024
@arboleya arboleya added this to the Caterpillar v1 milestone Aug 2, 2024
@arboleya
Copy link
Member

arboleya commented Sep 7, 2024

Closing in favor of:

@arboleya arboleya closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

No branches or pull requests

5 participants