Versioning of sub parameters #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced default `MAX_SIZE` to be 110kb. Reduced default `MAX_CONTRACT_SIZE` to be 100kb.
xgreenx
commented
Mar 21, 2024
Base automatically changed from
feature/versioning-consensus-parameters
to
master
March 21, 2024 22:11
# Conflicts: # CHANGELOG.md # fuel-tx/src/builder.rs # fuel-tx/src/tests/valid_cases/transaction.rs # fuel-tx/src/transaction/consensus_parameters.rs # fuel-vm/src/checked_transaction.rs # fuel-vm/src/tests/limits.rs # fuel-vm/src/tests/validation.rs
xgreenx
force-pushed
the
feature/versioning-sub-parameters
branch
from
1dc819b
to
38e515d
Compare
# Conflicts: # fuel-tx/src/transaction/consensus_parameters.rs # fuel-vm/src/tests/validation.rs
Dentosal
reviewed
Mar 25, 2024
| impl PredicateParameters { | ||
| /// Default consensus parameters with settings suggested in fuel-specs | ||
| impl PredicateParametersV1 { | ||
| /// Default parameters just for testing. |
There was a problem hiding this comment.
If these are just for testing, shouldn't we feature-gate them?
There was a problem hiding this comment.
Yeah, it is what we want=) I will put them under test-helpers in a separate PR
Dentosal
approved these changes
Mar 25, 2024
This was referenced Mar 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapped
FeeParameters,PredicateParameters,TxParameters,ScriptParametersandContractParametersinto an enum to support versioning.