Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent wasm-snip symbol stripping #408

Open
ra0x3 opened this issue Dec 8, 2022 · 4 comments
Open

Prevent wasm-snip symbol stripping #408

ra0x3 opened this issue Dec 8, 2022 · 4 comments
Assignees
Labels
blocked This change is currently blocked by a linked issue bug Something isn't working fuel-explorer This PR is directly related to the block explorer P: High
Milestone

Comments

@ra0x3
Copy link
Contributor

ra0x3 commented Dec 8, 2022

  • We had an issue with errant symbols getting into WASM binaries due to upstream fuel-core dependencies
  • We created a temporary hack to strip out these errant symbols
  • Stripping these symbols also means we can't use functionality that technically compiles to WASM (e.g., chrono)
  • We should follow up and make sure upstream dependencies compile to WASM (with no errant symbols or hacks) so that we can get full usage out of WASM

Additional context

  • @Br1ght0ne seems to be handling this on the fuel-core side
@ra0x3 ra0x3 added bug Something isn't working fyi labels Dec 8, 2022
@ra0x3 ra0x3 mentioned this issue Dec 8, 2022
16 tasks
@deekerno deekerno added the blocked This change is currently blocked by a linked issue label Dec 21, 2022
@deekerno
Copy link
Contributor

deekerno commented Dec 21, 2022

For clarity's sake, this is blocked by work on the fuel-core side.

@deekerno deekerno removed their assignment Dec 22, 2022
@ra0x3 ra0x3 mentioned this issue Jan 26, 2023
10 tasks
@ra0x3 ra0x3 added this to the beta-4 milestone Jan 26, 2023
@ra0x3 ra0x3 self-assigned this Jan 30, 2023
@deekerno deekerno added the devx label Jan 31, 2023
@ra0x3 ra0x3 added the fuel-explorer This PR is directly related to the block explorer label May 8, 2023
@ra0x3
Copy link
Contributor Author

ra0x3 commented May 17, 2023

FuelLabs/fuels-rs#970

@ra0x3
Copy link
Contributor Author

ra0x3 commented Jun 14, 2023

@deekerno
Copy link
Contributor

Just for more information, this is what is produced running cargo tree -i wasm-bindgen --target wasm32-unknown-unknown for fuel-explorer:

❯ cargo tree -i wasm-bindgen
wasm-bindgen v0.2.87
├── chrono v0.4.26
│   └── fuels-core v0.46.0
│       └── fuels v0.46.0
│           ├── fuel-indexer-types v0.19.5 (/home/deekerno/dev/fuel/indexer/packages/fuel-indexer-types)
│           │   ├── fuel-indexer-plugin v0.19.5 (/home/deekerno/dev/fuel/indexer/packages/fuel-indexer-plugin)
│           │   │   └── fuel-indexer-utils v0.19.5 (/home/deekerno/dev/fuel/indexer/packages/fuel-indexer-utils)
│           │   │       └── fuel_explorer v0.0.0 (/home/deekerno/dev/fuel/indexer/examples/fuel-explorer/fuel-explorer)
│           │   └── fuel-indexer-schema v0.19.5 (/home/deekerno/dev/fuel/indexer/packages/fuel-indexer-schema)
│           │       └── fuel-indexer-plugin v0.19.5 (/home/deekerno/dev/fuel/indexer/packages/fuel-indexer-plugin) (*)
│           └── fuel_explorer v0.0.0 (/home/deekerno/dev/fuel/indexer/examples/fuel-explorer/fuel-explorer)
├── getrandom v0.2.10
│   ├── coins-bip32 v0.8.3
│   │   ├── coins-bip39 v0.8.6
│   │   │   └── fuel-crypto v0.35.3
│   │   │       ├── fuel-tx v0.35.3
│   │   │       │   ├── fuel-indexer-types v0.19.5 (/home/deekerno/dev/fuel/indexer/packages/fuel-indexer-types) (*)
│   │   │       │   ├── fuel-vm v0.35.3
│   │   │       │   │   ├── fuel-core-storage v0.20.4
│   │   │       │   │   │   └── fuel-core-chain-config v0.20.4
│   │   │       │   │   │       └── fuels-core v0.46.0 (*)
│   │   │       │   │   ├── fuel-core-types v0.20.4
│   │   │       │   │   │   ├── fuel-core-chain-config v0.20.4 (*)
│   │   │       │   │   │   └── fuel-core-storage v0.20.4 (*)
│   │   │       │   │   └── fuels-core v0.46.0 (*)
│   │   │       │   ├── fuels v0.46.0 (*)
│   │   │       │   └── fuels-core v0.46.0 (*)
│   │   │       └── fuel-vm v0.35.3 (*)
│   │   └── fuel-crypto v0.35.3 (*)
│   ├── coins-bip39 v0.8.6 (*)
│   └── rand_core v0.6.4
│       ├── crypto-bigint v0.5.2
│       │   └── elliptic-curve v0.13.5
│       │       ├── ecdsa v0.16.8
│       │       │   ├── fuel-crypto v0.35.3 (*)
│       │       │   ├── k256 v0.13.1
│       │       │   │   └── coins-bip32 v0.8.3 (*)
│       │       │   └── p256 v0.13.2
│       │       │       └── fuel-crypto v0.35.3 (*)
│       │       ├── k256 v0.13.1 (*)
│       │       ├── p256 v0.13.2 (*)
│       │       └── primeorder v0.13.2
│       │           └── p256 v0.13.2 (*)
│       ├── elliptic-curve v0.13.5 (*)
│       ├── ff v0.13.0
│       │   ├── elliptic-curve v0.13.5 (*)
│       │   └── group v0.13.0
│       │       └── elliptic-curve v0.13.5 (*)
│       ├── group v0.13.0 (*)
│       ├── rand v0.8.5
│       │   ├── coins-bip39 v0.8.6 (*)
│       │   ├── fuel-core-chain-config v0.20.4 (*)
│       │   ├── fuel-crypto v0.35.3 (*)
│       │   ├── fuel-tx v0.35.3 (*)
│       │   ├── fuel-types v0.35.3
│       │   │   ├── fuel-crypto v0.35.3 (*)
│       │   │   ├── fuel-indexer-types v0.19.5 (/home/deekerno/dev/fuel/indexer/packages/fuel-indexer-types) (*)
│       │   │   ├── fuel-tx v0.35.3 (*)
│       │   │   ├── fuel-vm v0.35.3 (*)
│       │   │   └── fuels-core v0.46.0 (*)
│       │   ├── fuel-vm v0.35.3 (*)
│       │   └── secp256k1 v0.26.0
│       │       └── fuel-crypto v0.35.3 (*)
│       ├── rand_chacha v0.3.1
│       │   └── rand v0.8.5 (*)
│       └── signature v2.1.0
│           ├── ecdsa v0.16.8 (*)
│           └── k256 v0.13.1 (*)
└── js-sys v0.3.64
    ├── chrono v0.4.26 (*)
    └── getrandom v0.2.10 (*)

@ra0x3 ra0x3 added the P: High label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This change is currently blocked by a linked issue bug Something isn't working fuel-explorer This PR is directly related to the block explorer P: High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants