Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 405 onforc index deploy unless forc-index version matches fuel-indexer version #1377

Closed
ra0x3 opened this issue Sep 26, 2023 · 1 comment · Fixed by #1400
Closed
Assignees

Comments

@ra0x3
Copy link
Contributor

ra0x3 commented Sep 26, 2023

  • Indexers compiled with different fuel-indexer and forc-index versions always present issues
    • Because we can have non-trivial changes between even patch versions
  • We should add a VERSION to the indexer module that indicates what version of forc-index it was compiled with
  • When deployed via forc-index deploy if the compiled VERSION does not match the version of the service being used, should return a 405
  • We might remove this of feature flag it in the future, but for now this tends to always be an issue
@ra0x3 ra0x3 changed the title Return 405 onforc index deploy unless forc index version matches fuel-indexer version Return 405 onforc index deploy unless forc-index version matches fuel-indexer version Sep 26, 2023
@ra0x3
Copy link
Contributor Author

ra0x3 commented Sep 26, 2023

@lostman

  • For this, I'm wondering if it would be possible to add a const VERSION to the indexer modules, and then extract this VERSION on forc index deploy in fuel_indexer_api_server::uses::register_indexer_assets, and compare it to fuel_indexer_lib::config::IndexerConfig::version
  • Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants