Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using Sway example app ABI as a part of CI #1336

Closed
ra0x3 opened this issue Sep 6, 2023 · 0 comments · Fixed by #1341
Closed

Try using Sway example app ABI as a part of CI #1336

ra0x3 opened this issue Sep 6, 2023 · 0 comments · Fixed by #1341
Assignees

Comments

@ra0x3
Copy link
Contributor

ra0x3 commented Sep 6, 2023

  • We have two parts to our codegen (1) using GraphQL schema (2) using JSON-format of Sway contract ABI
  • Our #[indexer] macro uses codegen part number 2 (Sway ABI)
  • We only have really simple contract ABIs in our tests (fuel-indexer-test, simple-wasm)
  • It was suggested that if we want "real world" ABIs, we should ensure our tests work for Sway example app ABI
  • This could be a part of our trybuild tests potentially
  • We essentially just want to make sure our #[indexer] macros successfully compile in a number of "real world" situations
  • This has some priority because this would help us detect breakage before grantees (who write "real world" contracts) do
@ra0x3 ra0x3 added the P: Medium label Sep 6, 2023
@ra0x3 ra0x3 self-assigned this Sep 11, 2023
@ra0x3 ra0x3 linked a pull request Sep 28, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant