Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error codes to WASM executors #1156

Closed
ra0x3 opened this issue Jul 28, 2023 · 0 comments · Fixed by #1337
Closed

Add error codes to WASM executors #1156

ra0x3 opened this issue Jul 28, 2023 · 0 comments · Fixed by #1337
Assignees
@lostman
Labels
P: Medium

Comments

@ra0x3
Copy link
Contributor

ra0x3 commented Jul 28, 2023

  • Without error codes we have literally no way of knowing why these executors are having issues
  • We need to use error codes the similar to how we use thiserror error enums
  • Every panic/unwrap/expect should be associated with an error code
  • Example error:
2023-07-28T16:01:57.023060Z ERROR fuel_indexer::executor: 821: WasmIndexExecutor WASM execution failed: RuntimeError { source: Wasm { pc: 4540778896, backtrace:    0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lostman lostman

Labels
P: Medium
Projects
None yet
Milestone
No milestone
2 participants
@lostman @ra0x3