Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce types to represent denominations of the base asset (e.g. a Wei type and a Gwei type) #2248

Open
MitchTurner opened this issue Sep 25, 2024 · 0 comments
Assignees

Comments

@MitchTurner
Copy link
Member

MitchTurner commented Sep 25, 2024

There is a certain danger in doing conversions between different denominations all over the code. It could lead to hard-to-identify bugs if we have it wrong in a single place. We could avoid this by being explicit about which we are using.

The problem is that if we commit to Gwei and Wei, then it's harder to be an L2 of a different chain from Ethereum.

Maybe that is a future concern and the benefits of having these types is too great to avoid--we could solve for the abstraction later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant