Skip to content

Commit f9e98e7

Browse files
committed
πŸ§‘β€πŸ’» Unify Menu link url naming with Footer component
1 parent acf1121 commit f9e98e7

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

β€Žsrc/components/Menu/Menu.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ const wrapMenu = (logo?.url || logo?.html) && items?.length && Astro.slots.has('
5656
{items.map(item => (
5757
<li>
5858
<a
59-
href={item.url}
59+
href={item.href}
6060
target={item.target}
6161
class:list={[item.active && styles.active]}
6262
>

β€Žsrc/components/Menu/Menu.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
{#each items as item}
5656
<li>
5757
<a
58-
href={item.url}
58+
href={item.href}
5959
target={item.target}
6060
class={item.active ? styles.active : null}
6161
>

β€Žsrc/components/Menu/Menu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ const Menu = ({
6767
{items.map((item, index) => (
6868
<li key={index}>
6969
<a
70-
href={item.url}
70+
href={item.href}
7171
target={item.target}
7272
className={item.active ? styles.active : undefined}
7373
>

β€Žsrc/components/Menu/menu.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export type MenuProps = {
22
items?: {
3-
url: string
3+
href: string
44
name: string
55
target?: string
66
active?: boolean

β€Žsrc/data.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ export const overflowTabs = Array(10).fill({
7474
}))
7575

7676
export const menu = [
77-
{ name: 'Home', url: '/' },
78-
{ name: 'Docs', url: '/docs' }
77+
{ name: 'Home', href: '/' },
78+
{ name: 'Docs', href: '/docs' }
7979
]
8080

8181
export const menuLogo = {

β€Žsrc/static/Layout.astro

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ const menu = {
2121
html: logo
2222
},
2323
items: [
24-
{ url: '/svelte', name: 'Svelte', active: isPath('svelte') },
25-
{ url: '/react', name: 'React', active: isPath('react') },
26-
{ url: '/themes', name: 'Themes', active: isPath('themes') },
27-
{ url: '/resets', name: 'Resets', active: isPath('resets') },
28-
{ url: '/utilities', name: 'Utilities', active: isPath('utilities') }
24+
{ href: '/svelte', name: 'Svelte', active: isPath('svelte') },
25+
{ href: '/react', name: 'React', active: isPath('react') },
26+
{ href: '/themes', name: 'Themes', active: isPath('themes') },
27+
{ href: '/resets', name: 'Resets', active: isPath('resets') },
28+
{ href: '/utilities', name: 'Utilities', active: isPath('utilities') }
2929
]
3030
}
3131

0 commit comments

Comments
Β (0)