[BUGFIX] Do not use about:blank as src in other Webkit browsers than Chrome #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmack
reviewed
Mar 15, 2019
| @@ -214,7 +214,7 @@ define(['TYPO3/CMS/Rtehtmlarea/HTMLArea/UserAgent/UserAgent', | |||
| id: this.editorId + '-iframe', | |||
| tag: 'iframe', | |||
| cls: 'editorIframe', | |||
| src: UserAgent.isGecko ? 'javascript:void(0);' : (UserAgent.isWebKit ? 'about:blank;' : HTMLArea.editorUrl + 'Resources/Public/Html/blank.html') | |||
| src: UserAgent.isGecko ? 'javascript:void(0);' : (UserAgent.isWebKit ? (UserAgent.isChrome ? 'about:blank;' : 'javascript: \'' + Util.htmlEncode(this.config.documentType + this.config.blankDocument) + '\'' ): HTMLArea.editorUrl + 'Resources/Public/Html/blank.html') | |||
There was a problem hiding this comment.
could you fix the indention please?
|
What about Opera, Vivaldi? |
|
@pschriner are you able to test this in these browsers? |
|
I just installed Vivaldi 2.3.1440.61 now, htmlarea is still functional. |
|
On Opera 60.0.3254.0 (current developer), which seems to be based on Chrome 73 (Developer console whats new), the original version does not work (which means: about:blank is required). On Opera 59.x (based on chrome 72) it works (no surprises) This patch seems to work right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only Chrome needs
about:blankas iframe src as introduced in #28. Safarican't handle this and treats
about:blankas a cross origin.Resolves: #30
Related: #26