Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Use non-JavaScript based iframe src #28

Merged
merged 1 commit into from
Mar 15, 2019
Merged

[BUGFIX] Use non-JavaScript based iframe src #28

merged 1 commit into from
Mar 15, 2019

Conversation

andreaskienast
Copy link
Contributor

@andreaskienast andreaskienast commented Mar 14, 2019

Since the release of Chrome 73, iframe documents can't be loaded via
javascript protocol anymore. This commit changes the iframe src to
be an empty page for WebKit browsers.

Many thanks go to @guppy42 who identified the cause and proposed this fix.

Resolves: #26

Since the release of Chrome 73, iframe documents can't be loaded via
javascript protocol anymore. This commit changes the iframe src to
be an empty page for WebKit browsers.

Resolves: #26
@susannemoog susannemoog self-requested a review March 14, 2019 10:58
@bmack bmack merged commit 97a857f into FriendsOfTYPO3:master Mar 15, 2019
@guppy42
Copy link

guppy42 commented Mar 15, 2019

Unfortunately while this fixes Chrome it seems it now breaks safari instead - due to about:blank; being seen as cross origin.

To fix this turns the line into a bit of soup;

src: UserAgent.isGecko ? 'javascript:void(0);' : (UserAgent.isWebKit ? (UserAgent.isChrome ? 'about:blank;' : 'javascript: \'' + Util.htmlEncode(this.config.documentType + this.config.blankDocument) + '\'' ): HTMLArea.editorUrl + 'Resources/Public/Html/blank.html')

It's ugly but works - undoubtedly there is a more elegant solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression with Chrome 73 in Typo3 7.6.32
4 participants