Skip to content

[8.x Compatiblity] sfDebug::shortenFilePath #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2024
Merged

[8.x Compatiblity] sfDebug::shortenFilePath #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b39d71
Return early if empty
iricketson Dec 28, 2023
9ec41a1
Add test
iricketson Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/debug/sfDebug.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ public static function removeObjects($values)
*/
public static function shortenFilePath($file)
{
if (!$file) {
return $file;
}

foreach (array('sf_root_dir', 'sf_symfony_lib_dir') as $key) {
if (0 === strpos($file, $value = sfConfig::get($key))) {
$file = str_replace($value, strtoupper($key), $file);
Expand Down
5 changes: 4 additions & 1 deletion test/unit/debug/sfDebugTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,13 @@

require_once __DIR__.'/../../bootstrap/unit.php';

$t = new lime_test(1);
$t = new lime_test(2);

// ::removeObjects()
$t->diag('::removeObjects()');
$objectArray = array('foo', 42, new sfDebug(), array('bar', 23, new lime_test(null)));
$cleanedArray = array('foo', 42, 'sfDebug Object()', array('bar', 23, 'lime_test Object()'));
$t->is_deeply(sfDebug::removeObjects($objectArray), $cleanedArray, '::removeObjects() converts objects to String representations using the class name');

$t->diag('::shortenFilePath()');
$t->is(sfDebug::shortenFilePath(null), null, '->shortenFilePath() handles a null value');