Skip to content

Conversation

@alquerci
Copy link
Contributor

@alquerci alquerci commented Jan 22, 2022

Goal

  • Removes all side work for contributors that do not provide any value, except effective improvements
  • Provide the same testing environment for everyone.
  • Help contributors to win the big challenge of PHP new versions supports, while BC layer are kept.
  • Provide a bit more confidence during the development by reducing the testing feedback loop.

Usage

Look at the README.md.

In short

test/bin/test

Test results

Same matrix than travis-ci

PHP version Dependency Status
php53 highest 🟢
php54 highest 🟢
php55 highest 🟢
php56 highest 🟢
php70 highest 🟢
php71 highest 🟢
php72 highest 🟢
php73 highest 🔴
php74 highest 🔴
#   at [sfDoctrine] functional/AdminGenTest.php line 17
>   response selector "select" matches "NewActivePendingExpired"
           got: '
New
Active
Pending
Expired
'
      expected: 'NewActivePendingExpired'

New additional matrix (disabled by default)

PHP version Dependency Status
php53 lowest 🟢
php54 lowest 🟢
php55 lowest 🟢
php56 lowest 🟢
php70 lowest 🟢
php71 lowest 🟢
php72 lowest 🟢
php73 lowest 🔴
php74 lowest 🔴
php80 highest 🔴
php81 highest 🔴
php80 lowest 🔴
php81 lowest 🔴

Related to #261

@alquerci alquerci mentioned this pull request Jan 22, 2022
Copy link
Collaborator

@thirsch thirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small typo-fix

Copy link
Contributor Author

@alquerci alquerci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add apcu for PHP 5.5+

PHP 5 => 4.0.11
PHP 7+ => 5.1.21

@alquerci
Copy link
Contributor Author

alquerci commented Jan 23, 2022

News, APC tests failed on all versions, so by default there are disabled until patch is done.

>   ->set('test', 'some random data to store in the cache system... (\'"!#/é$£)', -10)
#   at unit/cache/sfCacheDriverTests.class.php line 22
>   ->get() returns the default value if cache has expired
           got: 'some random data to store in the cache system... (\'"!#/é$£)'
      expected: 'default'

Related to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=805883

And it seems that APC does not support negative lifetime.

* Add apcu for PHP 5.5+
* Disable APC on PHP 7+ as APCu 5 is not supported
* Add ability to use a custom test runtime

Co-authored-by: Thomas <th@it-solutions-hirsch.de>
@alquerci alquerci force-pushed the add-docker-compose branch from b88b2a5 to e8cbc9d Compare October 5, 2022 16:35
@alquerci
Copy link
Contributor Author

alquerci commented Oct 5, 2022

@thePanz I remind you that this PR is a dependency for all new one.

@thePanz
Copy link
Member

thePanz commented Nov 25, 2022

Please have a look at: #268

Would it be great to have the last errors fixed ... do you have any hint?

@thePanz thePanz merged commit 6b82513 into FriendsOfSymfony1:master Nov 25, 2022
@alquerci
Copy link
Contributor Author

@thePanz same concern as of FriendsOfSymfony1/doctrine1#89 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants