PHP 7.4 incompatibility fix: Passing the glue and pieces parameters in reverse order to implode has been deprecated since PHP 7.4

pathumhdes · pathumhdes · commit dae8d56e2930 · 2020-05-02T07:44:04.000+05:30
diff --git a/lib/view/sfViewCacheManager.class.php b/lib/view/sfViewCacheManager.class.php
@@ -236,7 +236,7 @@ protected function getCacheKeyVaryHeaderPart($internalUri, $vary = '')
       {
         $varys[] = $header . '-' . preg_replace('/\W+/', '_', $request->getHttpHeader($header));
       }
-      $vary = implode($varys, '-');
+      $vary = implode('-', $varys);
     }
 
     return $vary;

Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,7 @@ protected function getCacheKeyVaryHeaderPart($internalUri, $vary = '')`
`236`	`236`	`{`
`237`	`237`	`$varys[] = $header . '-' . preg_replace('/\W+/', '_', $request->getHttpHeader($header));`
`238`	`238`	`}`
`239`		`- $vary = implode($varys, '-');`
	`239`	`+ $vary = implode('-', $varys);`
`240`	`240`	`}`
`241`	`241`
`242`	`242`	`return $vary;`