Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test support for CI #16

Open
FriedrichFroebel opened this issue May 28, 2020 · 1 comment
Open

Add test support for CI #16

FriedrichFroebel opened this issue May 28, 2020 · 1 comment

Comments

@FriedrichFroebel
Copy link
Owner

There currently are no automated tests on Travis CI. While I would be able to enable these for commits to the master branch, they would not work for pull requests as I would have to expose an Opencaching.de password to the public due to Travis not allowing access to secret variables on external contributions (which perfectly makes sense to avoid exposing it due to malicious contributors).

We might avoid this by mocking network calls. There would be the option to set-up an own site with the Opencaching.de server code to use for each test, but the tests would take a lot of time afterwards. Using the real site for each commit on the master branch and for pull requests might introduce additional traffic which I am not sure either.

Additionally all tests requiring write access (or existing logs) at Opencaching.de have currently been disabled. This is the case as I do not want to do development tests on the production server. We might come up with a appropriate solution for this in the same step (or in another one). (There is a public test server, but it currently is in maintenance mode and OKAPI e-mails are not sent for now.)

@FriedrichFroebel
Copy link
Owner Author

The last paragraph is not valid any more since 76e4ca7 as the e-mail problem with the test server has been fixed in June.

@FriedrichFroebel FriedrichFroebel changed the title Add test support for Travis Add test support for CI Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant