Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text color not always visible #174

Closed
XanderD99 opened this issue Jan 15, 2024 · 2 comments · Fixed by #175
Closed

Text color not always visible #174

XanderD99 opened this issue Jan 15, 2024 · 2 comments · Fixed by #175

Comments

@XanderD99
Copy link

Describe the bug
TalkerScreenTheme textColor is not used consistently throughout the TalkerScreen page

To Reproduce
Steps to reproduce the behavior:

  1. Create talkerscreen with white background
  2. go to talkerscreen
  3. you'll see that not all text is readable

Expected behavior
Text to be readable when background is not dark

Screenshots
Screenshot 2024-01-15 at 16 50 39
Screenshot 2024-01-15 at 16 50 32

@XanderD99
Copy link
Author

code snippet:

TalkerScreen(
  talker: talker,
  theme: TalkerScreenTheme(
    backgroundColor: context.colorScheme.background,
    textColor: context.colorScheme.onBackground,
    cardColor: context.colorScheme.surface,
  ),
);

@Frezyx
Copy link
Owner

Frezyx commented Jan 21, 2024

Hello @XanderD99 !
Thank you for this issue, I will check it in near future

@Frezyx Frezyx linked a pull request Jan 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants