Skip to content

Conversation

@Kevin4335
Copy link

@Kevin4335 Kevin4335 commented Apr 23, 2025

Shows a preview for non-melee abilities that disappears after a delay when clicking an ability when it is unavailable. Changes the way handling abilities work with a new isPreview condition for query. Possible phase out the strict way of disabling abilities after 1 use and simply treats them as lacking suitable targets.

This fixes issue #970

(I do not have a ERC20 wallet)

@vercel
Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Apr 23, 2025 7:24pm

@DreadKnight
Copy link
Member

@Kevin4335 This breaks the game. Notice the builds around here.
Also referencing issues is done by using hashtag and issue number.

@Kevin4335
Copy link
Author

Locally, it passed the Jest tests and it seems to run.

@DreadKnight
Copy link
Member

Locally, it passed the Jest tests and it seems to run.

@Kevin4335 I bet, but you know how development goes when it comes to different machines... you could also poke at a browser based IDE, even Github provides one. Usually there's a small thing that breaks big changes on various set-ups.

@DreadKnight DreadKnight changed the title issue 970 showcase ability range on click fix Apr 26, 2025
@DreadKnight DreadKnight changed the title showcase ability range on click fix showcase ability range on click Apr 26, 2025
@DreadKnight
Copy link
Member

@Kevin4335 Really looking forward to test out this patch! 🤞🏻
No pressure, but note that if it takes too long, it might have some conflicts to resolve when trying to merge this into master 🐻

@DreadKnight
Copy link
Member

@Kevin4335 Any progress with this? Another week passed and this is starting to have conflicts...

@DreadKnight
Copy link
Member

@Kevin4335 Guess you went M.I.A... too bad, all this work will go to waste soon or it will take extra work, as there are PRs like this one that will get merged soon -> https://github.com/FreezingMoon/AncientBeast/pull/2733/files

@DreadKnight
Copy link
Member

@Kevin4335 You can test it out over here: https://ancientbeast-is6exrk7h-freezingmoon.vercel.app/
Each new commit a new preview is being built and linked around here using a new link.

I've found some errors regarding the audio UI button, which is missing and errors show in console.
Got things going by using right click and materializing a unit and the UI appeared.
Though for screenshots, the unit queue vanishes, but that's a different issue altogether:
Screenshot_20250527_102613

Note that the UI audio button has been worked on recently and uses different icons, as you can right click it to change audio modes. Hopefully this will get you on the right track and fix this, though it will need some conflict resolves as well before merges, provided the tests go well 🐻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants