Skip to content

Commit d81130c

Browse files
committed
tds: Do not accept negative values for some configuration
Negative values do not make sense for TCP port and TEXTSIZE. Negative timeout values are not valid. Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
1 parent ed7f87a commit d81130c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/tds/config.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -634,10 +634,10 @@ tds_parse_conf_section(const char *option, const char *value, void *param)
634634
if (*value != '\0' && *end == '\0' && flags > INT_MIN && flags < INT_MAX)
635635
login->debug_flags = (int) flags;
636636
} else if (!strcmp(option, TDS_STR_TIMEOUT) || !strcmp(option, TDS_STR_QUERY_TIMEOUT)) {
637-
if (atoi(value))
637+
if (atoi(value) > 0)
638638
login->query_timeout = atoi(value);
639639
} else if (!strcmp(option, TDS_STR_CONNTIMEOUT)) {
640-
if (atoi(value))
640+
if (atoi(value) > 0)
641641
login->connect_timeout = atoi(value);
642642
} else if (!strcmp(option, TDS_STR_HOST)) {
643643
char tmp[128];
@@ -654,13 +654,13 @@ tds_parse_conf_section(const char *option, const char *value, void *param)
654654
tdsdump_log(TDS_DBG_INFO1, "IP addr is %s.\n", tds_addrinfo2str(addrs, tmp, sizeof(tmp)));
655655

656656
} else if (!strcmp(option, TDS_STR_PORT)) {
657-
if (atoi(value))
657+
if (atoi(value) > 0)
658658
login->port = atoi(value);
659659
} else if (!strcmp(option, TDS_STR_EMUL_LE)) {
660660
/* obsolete, ignore */
661661
tds_config_boolean(option, value, login);
662662
} else if (!strcmp(option, TDS_STR_TEXTSZ)) {
663-
if (atoi(value))
663+
if (atoi(value) > 0)
664664
login->text_size = atoi(value);
665665
} else if (!strcmp(option, TDS_STR_CHARSET)) {
666666
s = tds_dstr_copy(&login->server_charset, value);

0 commit comments

Comments
 (0)