Define default values of macros before first use #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configSTACK_ALLOCATION_FROM_SEPARATE_HEAP was added recently in FreeRTOS#267. This macro was used in portable.h before its default value was defined, resulting in a warning when built with -Wundef. This changes moves the default value definition for configSTACK_ALLOCATION_FROM_SEPARATE_HEAP to portable.h to ensure that it is defined before first use. portUSING_MPU_WRAPPERS check in mpu_wrappers.h was updated in FreeRTOS#285. The new check results in a warning when built with -Wundef because portUSING_MPU_WRAPPERS is not defined yet. This changes adds the default value definition for portUSING_MPU_WRAPPERS to portable.h to ensure that it is defined before first use. Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
alfred2g
reviewed
Mar 31, 2021
alfred2g
approved these changes
Apr 1, 2021
RichardBarry
approved these changes
Apr 1, 2021
Codecov Report
@@ Coverage Diff @@
## main #298 +/- ##
============================================
- Coverage 100.00% 79.34% -20.66%
============================================
Files 1 1
Lines 37 184 +147
Branches 3 45 +42
============================================
+ Hits 37 146 +109
- Misses 0 14 +14
- Partials 0 24 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Note regarding the codecov report: A new unit test was added which caused the decrease in line coverage. This was not due to the changes in this PR. |
n9wxu
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
configSTACK_ALLOCATION_FROM_SEPARATE_HEAPwas added recently in #267. This macro was used inportable.hbefore its default value was defined inFreeRTOS.h, resulting in a warning when built with-Wundef. This change moves the default value definition forconfigSTACK_ALLOCATION_FROM_SEPARATE_HEAPtoportable.hto ensure that it is defined before first use.portUSING_MPU_WRAPPERScheck inmpu_wrappers.hwas updated in #285. The new check results in a warning when built with-WundefbecauseportUSING_MPU_WRAPPERSis not defined yet. This change adds the default value definition forportUSING_MPU_WRAPPERStoportable.hto ensure that it is defined before first use.Test Steps
Built the code with the following flags:
-Wunused -Wuninitialized -Wall -Wextra -Wmissing-declarations -Wpointer-arith -Wbad-function-cast -Wshadow -Wstrict-prototypes -Wmissing-prototypes -WundefRelated Issue
https://forums.freertos.org/t/freertos-kernel-repos-pr-267-is-insufficient-for-high-warning-level-compile-option/12155
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.