Skip to content

Commit 11c72bc

Browse files
moninom1moninom1
authored
Add support for MISRA rule 20.7 (#546)
Misra rule 20.7 requires parenthesis to all parameter names in macro definitions. The issue was reported here : https://forums.freertos.org/t/misra-20-7-compatibility/15385
1 parent 992ff1b commit 11c72bc

12 files changed

+88
-88
lines changed

‎.github/workflows/unit-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424

2525
- name: Install packages
2626
run: |
27-
sudo apt-get install lcov cflow ruby doxygen build-essential
27+
sudo apt-get install lcov cflow ruby doxygen build-essential unifdef
2828
- name: Run Unit Tests with ENABLE_SANITIZER=1
2929
run: |
3030
make -C FreeRTOS/Test/CMock clean

‎croutine.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,13 @@
6565
* This macro accesses the co-routine ready lists and therefore must not be
6666
* used from within an ISR.
6767
*/
68-
#define prvAddCoRoutineToReadyQueue( pxCRCB ) \
69-
{ \
70-
if( pxCRCB->uxPriority > uxTopCoRoutineReadyPriority ) \
71-
{ \
72-
uxTopCoRoutineReadyPriority = pxCRCB->uxPriority; \
73-
} \
74-
vListInsertEnd( ( List_t * ) &( pxReadyCoRoutineLists[ pxCRCB->uxPriority ] ), &( pxCRCB->xGenericListItem ) ); \
68+
#define prvAddCoRoutineToReadyQueue( pxCRCB ) \
69+
{ \
70+
if( ( pxCRCB )->uxPriority > uxTopCoRoutineReadyPriority ) \
71+
{ \
72+
uxTopCoRoutineReadyPriority = ( pxCRCB )->uxPriority; \
73+
} \
74+
vListInsertEnd( ( List_t * ) &( pxReadyCoRoutineLists[ ( pxCRCB )->uxPriority ] ), &( ( pxCRCB )->xGenericListItem ) ); \
7575
}
7676

7777
/*

‎include/FreeRTOS.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -360,19 +360,19 @@
360360
#endif
361361

362362
#ifndef portCLEAR_INTERRUPT_MASK_FROM_ISR
363-
#define portCLEAR_INTERRUPT_MASK_FROM_ISR( uxSavedStatusValue ) ( void ) uxSavedStatusValue
363+
#define portCLEAR_INTERRUPT_MASK_FROM_ISR( uxSavedStatusValue ) ( void ) ( uxSavedStatusValue )
364364
#endif
365365

366366
#ifndef portCLEAN_UP_TCB
367-
#define portCLEAN_UP_TCB( pxTCB ) ( void ) pxTCB
367+
#define portCLEAN_UP_TCB( pxTCB ) ( void ) ( pxTCB )
368368
#endif
369369

370370
#ifndef portPRE_TASK_DELETE_HOOK
371371
#define portPRE_TASK_DELETE_HOOK( pvTaskToDelete, pxYieldPending )
372372
#endif
373373

374374
#ifndef portSETUP_TCB
375-
#define portSETUP_TCB( pxTCB ) ( void ) pxTCB
375+
#define portSETUP_TCB( pxTCB ) ( void ) ( pxTCB )
376376
#endif
377377

378378
#ifndef configQUEUE_REGISTRY_SIZE
@@ -684,15 +684,15 @@
684684
#endif
685685

686686
#ifndef traceEVENT_GROUP_SYNC_END
687-
#define traceEVENT_GROUP_SYNC_END( xEventGroup, uxBitsToSet, uxBitsToWaitFor, xTimeoutOccurred ) ( void ) xTimeoutOccurred
687+
#define traceEVENT_GROUP_SYNC_END( xEventGroup, uxBitsToSet, uxBitsToWaitFor, xTimeoutOccurred ) ( void ) ( xTimeoutOccurred )
688688
#endif
689689

690690
#ifndef traceEVENT_GROUP_WAIT_BITS_BLOCK
691691
#define traceEVENT_GROUP_WAIT_BITS_BLOCK( xEventGroup, uxBitsToWaitFor )
692692
#endif
693693

694694
#ifndef traceEVENT_GROUP_WAIT_BITS_END
695-
#define traceEVENT_GROUP_WAIT_BITS_END( xEventGroup, uxBitsToWaitFor, xTimeoutOccurred ) ( void ) xTimeoutOccurred
695+
#define traceEVENT_GROUP_WAIT_BITS_END( xEventGroup, uxBitsToWaitFor, xTimeoutOccurred ) ( void ) ( xTimeoutOccurred )
696696
#endif
697697

698698
#ifndef traceEVENT_GROUP_CLEAR_BITS
@@ -1023,7 +1023,7 @@
10231023
#define portTICK_TYPE_ENTER_CRITICAL()
10241024
#define portTICK_TYPE_EXIT_CRITICAL()
10251025
#define portTICK_TYPE_SET_INTERRUPT_MASK_FROM_ISR() 0
1026-
#define portTICK_TYPE_CLEAR_INTERRUPT_MASK_FROM_ISR( x ) ( void ) x
1026+
#define portTICK_TYPE_CLEAR_INTERRUPT_MASK_FROM_ISR( x ) ( void ) ( x )
10271027
#endif /* if ( portTICK_TYPE_IS_ATOMIC == 0 ) */
10281028

10291029
/* Definitions to allow backward compatibility with FreeRTOS versions prior to

‎include/event_groups.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ EventBits_t xEventGroupClearBits( EventGroupHandle_t xEventGroup,
423423
const EventBits_t uxBitsToClear ) PRIVILEGED_FUNCTION;
424424
#else
425425
#define xEventGroupClearBitsFromISR( xEventGroup, uxBitsToClear ) \
426-
xTimerPendFunctionCallFromISR( vEventGroupClearBitsCallback, ( void * ) xEventGroup, ( uint32_t ) uxBitsToClear, NULL )
426+
xTimerPendFunctionCallFromISR( vEventGroupClearBitsCallback, ( void * ) ( xEventGroup ), ( uint32_t ) ( uxBitsToClear ), NULL )
427427
#endif
428428

429429
/**
@@ -579,7 +579,7 @@ EventBits_t xEventGroupSetBits( EventGroupHandle_t xEventGroup,
579579
BaseType_t * pxHigherPriorityTaskWoken ) PRIVILEGED_FUNCTION;
580580
#else
581581
#define xEventGroupSetBitsFromISR( xEventGroup, uxBitsToSet, pxHigherPriorityTaskWoken ) \
582-
xTimerPendFunctionCallFromISR( vEventGroupSetBitsCallback, ( void * ) xEventGroup, ( uint32_t ) uxBitsToSet, pxHigherPriorityTaskWoken )
582+
xTimerPendFunctionCallFromISR( vEventGroupSetBitsCallback, ( void * ) ( xEventGroup ), ( uint32_t ) ( uxBitsToSet ), ( pxHigherPriorityTaskWoken ) )
583583
#endif
584584

585585
/**
@@ -728,7 +728,7 @@ EventBits_t xEventGroupSync( EventGroupHandle_t xEventGroup,
728728
* \defgroup xEventGroupGetBits xEventGroupGetBits
729729
* \ingroup EventGroup
730730
*/
731-
#define xEventGroupGetBits( xEventGroup ) xEventGroupClearBits( xEventGroup, 0 )
731+
#define xEventGroupGetBits( xEventGroup ) xEventGroupClearBits( ( xEventGroup ), 0 )
732732

733733
/**
734734
* event_groups.h

‎include/message_buffer.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -156,11 +156,11 @@ typedef StreamBufferHandle_t MessageBufferHandle_t;
156156
* \ingroup MessageBufferManagement
157157
*/
158158
#define xMessageBufferCreate( xBufferSizeBytes ) \
159-
xStreamBufferGenericCreate( xBufferSizeBytes, ( size_t ) 0, pdTRUE, NULL, NULL )
159+
xStreamBufferGenericCreate( ( xBufferSizeBytes ), ( size_t ) 0, pdTRUE, NULL, NULL )
160160

161161
#if ( configUSE_SB_COMPLETED_CALLBACK == 1 )
162162
#define xMessageBufferCreateWithCallback( xBufferSizeBytes, pxSendCompletedCallback, pxReceiveCompletedCallback ) \
163-
xStreamBufferGenericCreate( xBufferSizeBytes, ( size_t ) 0, pdTRUE, pxSendCompletedCallback, pxReceiveCompletedCallback )
163+
xStreamBufferGenericCreate( ( xBufferSizeBytes ), ( size_t ) 0, pdTRUE, ( pxSendCompletedCallback ), ( pxReceiveCompletedCallback ) )
164164
#endif
165165

166166
/**
@@ -238,11 +238,11 @@ typedef StreamBufferHandle_t MessageBufferHandle_t;
238238
* \ingroup MessageBufferManagement
239239
*/
240240
#define xMessageBufferCreateStatic( xBufferSizeBytes, pucMessageBufferStorageArea, pxStaticMessageBuffer ) \
241-
xStreamBufferGenericCreateStatic( xBufferSizeBytes, 0, pdTRUE, pucMessageBufferStorageArea, pxStaticMessageBuffer, NULL, NULL )
241+
xStreamBufferGenericCreateStatic( ( xBufferSizeBytes ), 0, pdTRUE, ( pucMessageBufferStorageArea ), ( pxStaticMessageBuffer ), NULL, NULL )
242242

243243
#if ( configUSE_SB_COMPLETED_CALLBACK == 1 )
244244
#define xMessageBufferCreateStaticWithCallback( xBufferSizeBytes, pucMessageBufferStorageArea, pxStaticMessageBuffer, pxSendCompletedCallback, pxReceiveCompletedCallback ) \
245-
xStreamBufferGenericCreateStatic( xBufferSizeBytes, 0, pdTRUE, pucMessageBufferStorageArea, pxStaticMessageBuffer, pxSendCompletedCallback, pxReceiveCompletedCallback )
245+
xStreamBufferGenericCreateStatic( ( xBufferSizeBytes ), 0, pdTRUE, ( pucMessageBufferStorageArea ), ( pxStaticMessageBuffer ), ( pxSendCompletedCallback ), ( pxReceiveCompletedCallback ) )
246246
#endif
247247

248248
/**
@@ -343,7 +343,7 @@ typedef StreamBufferHandle_t MessageBufferHandle_t;
343343
* \ingroup MessageBufferManagement
344344
*/
345345
#define xMessageBufferSend( xMessageBuffer, pvTxData, xDataLengthBytes, xTicksToWait ) \
346-
xStreamBufferSend( xMessageBuffer, pvTxData, xDataLengthBytes, xTicksToWait )
346+
xStreamBufferSend( ( xMessageBuffer ), ( pvTxData ), ( xDataLengthBytes ), ( xTicksToWait ) )
347347

348348
/**
349349
* message_buffer.h
@@ -448,7 +448,7 @@ typedef StreamBufferHandle_t MessageBufferHandle_t;
448448
* \ingroup MessageBufferManagement
449449
*/
450450
#define xMessageBufferSendFromISR( xMessageBuffer, pvTxData, xDataLengthBytes, pxHigherPriorityTaskWoken ) \
451-
xStreamBufferSendFromISR( xMessageBuffer, pvTxData, xDataLengthBytes, pxHigherPriorityTaskWoken )
451+
xStreamBufferSendFromISR( ( xMessageBuffer ), ( pvTxData ), ( xDataLengthBytes ), ( pxHigherPriorityTaskWoken ) )
452452

453453
/**
454454
* message_buffer.h
@@ -537,7 +537,7 @@ typedef StreamBufferHandle_t MessageBufferHandle_t;
537537
* \ingroup MessageBufferManagement
538538
*/
539539
#define xMessageBufferReceive( xMessageBuffer, pvRxData, xBufferLengthBytes, xTicksToWait ) \
540-
xStreamBufferReceive( xMessageBuffer, pvRxData, xBufferLengthBytes, xTicksToWait )
540+
xStreamBufferReceive( ( xMessageBuffer ), ( pvRxData ), ( xBufferLengthBytes ), ( xTicksToWait ) )
541541

542542

543543
/**
@@ -639,7 +639,7 @@ typedef StreamBufferHandle_t MessageBufferHandle_t;
639639
* \ingroup MessageBufferManagement
640640
*/
641641
#define xMessageBufferReceiveFromISR( xMessageBuffer, pvRxData, xBufferLengthBytes, pxHigherPriorityTaskWoken ) \
642-
xStreamBufferReceiveFromISR( xMessageBuffer, pvRxData, xBufferLengthBytes, pxHigherPriorityTaskWoken )
642+
xStreamBufferReceiveFromISR( ( xMessageBuffer ), ( pvRxData ), ( xBufferLengthBytes ), ( pxHigherPriorityTaskWoken ) )
643643

644644
/**
645645
* message_buffer.h
@@ -804,7 +804,7 @@ typedef StreamBufferHandle_t MessageBufferHandle_t;
804804
* \ingroup StreamBufferManagement
805805
*/
806806
#define xMessageBufferSendCompletedFromISR( xMessageBuffer, pxHigherPriorityTaskWoken ) \
807-
xStreamBufferSendCompletedFromISR( xMessageBuffer, pxHigherPriorityTaskWoken )
807+
xStreamBufferSendCompletedFromISR( ( xMessageBuffer ), ( pxHigherPriorityTaskWoken ) )
808808

809809
/**
810810
* message_buffer.h
@@ -845,7 +845,7 @@ typedef StreamBufferHandle_t MessageBufferHandle_t;
845845
* \ingroup StreamBufferManagement
846846
*/
847847
#define xMessageBufferReceiveCompletedFromISR( xMessageBuffer, pxHigherPriorityTaskWoken ) \
848-
xStreamBufferReceiveCompletedFromISR( xMessageBuffer, pxHigherPriorityTaskWoken )
848+
xStreamBufferReceiveCompletedFromISR( ( xMessageBuffer ), ( pxHigherPriorityTaskWoken ) )
849849

850850
/* *INDENT-OFF* */
851851
#if defined( __cplusplus )

‎include/mpu_wrappers.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,10 +182,10 @@
182182
#define xPortRaisePrivilege( xRunningPrivileged ) \
183183
{ \
184184
/* Check whether the processor is already privileged. */ \
185-
xRunningPrivileged = portIS_PRIVILEGED(); \
185+
( xRunningPrivileged ) = portIS_PRIVILEGED(); \
186186
\
187187
/* If the processor is not already privileged, raise privilege. */ \
188-
if( xRunningPrivileged == pdFALSE ) \
188+
if( ( xRunningPrivileged ) == pdFALSE ) \
189189
{ \
190190
portRAISE_PRIVILEGE(); \
191191
} \
@@ -197,7 +197,7 @@
197197
*/
198198
#define vPortResetPrivilege( xRunningPrivileged ) \
199199
{ \
200-
if( xRunningPrivileged == pdFALSE ) \
200+
if( ( xRunningPrivileged ) == pdFALSE ) \
201201
{ \
202202
portRESET_PRIVILEGE(); \
203203
} \

‎include/queue.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1478,7 +1478,7 @@ BaseType_t xQueueGiveMutexRecursive( QueueHandle_t xMutex ) PRIVILEGED_FUNCTION;
14781478
* Reset a queue back to its original empty state. The return value is now
14791479
* obsolete and is always set to pdPASS.
14801480
*/
1481-
#define xQueueReset( xQueue ) xQueueGenericReset( xQueue, pdFALSE )
1481+
#define xQueueReset( xQueue ) xQueueGenericReset( ( xQueue ), pdFALSE )
14821482

14831483
/*
14841484
* The registry is provided as a means for kernel aware debuggers to

‎include/semphr.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ typedef QueueHandle_t SemaphoreHandle_t;
225225
* \ingroup Semaphores
226226
*/
227227
#if ( configSUPPORT_STATIC_ALLOCATION == 1 )
228-
#define xSemaphoreCreateBinaryStatic( pxStaticSemaphore ) xQueueGenericCreateStatic( ( UBaseType_t ) 1, semSEMAPHORE_QUEUE_ITEM_LENGTH, NULL, pxStaticSemaphore, queueQUEUE_TYPE_BINARY_SEMAPHORE )
228+
#define xSemaphoreCreateBinaryStatic( pxStaticSemaphore ) xQueueGenericCreateStatic( ( UBaseType_t ) 1, semSEMAPHORE_QUEUE_ITEM_LENGTH, NULL, ( pxStaticSemaphore ), queueQUEUE_TYPE_BINARY_SEMAPHORE )
229229
#endif /* configSUPPORT_STATIC_ALLOCATION */
230230

231231
/**
@@ -940,7 +940,7 @@ typedef QueueHandle_t SemaphoreHandle_t;
940940
* \ingroup Semaphores
941941
*/
942942
#if ( ( configSUPPORT_STATIC_ALLOCATION == 1 ) && ( configUSE_RECURSIVE_MUTEXES == 1 ) )
943-
#define xSemaphoreCreateRecursiveMutexStatic( pxStaticSemaphore ) xQueueCreateMutexStatic( queueQUEUE_TYPE_RECURSIVE_MUTEX, pxStaticSemaphore )
943+
#define xSemaphoreCreateRecursiveMutexStatic( pxStaticSemaphore ) xQueueCreateMutexStatic( queueQUEUE_TYPE_RECURSIVE_MUTEX, ( pxStaticSemaphore ) )
944944
#endif /* configSUPPORT_STATIC_ALLOCATION */
945945

946946
/**

‎include/stream_buffer.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,11 +155,11 @@ typedef void (* StreamBufferCallbackFunction_t)( StreamBufferHandle_t xStreamBuf
155155
*/
156156

157157
#define xStreamBufferCreate( xBufferSizeBytes, xTriggerLevelBytes ) \
158-
xStreamBufferGenericCreate( xBufferSizeBytes, xTriggerLevelBytes, pdFALSE, NULL, NULL )
158+
xStreamBufferGenericCreate( ( xBufferSizeBytes ), ( xTriggerLevelBytes ), pdFALSE, NULL, NULL )
159159

160160
#if ( configUSE_SB_COMPLETED_CALLBACK == 1 )
161161
#define xStreamBufferCreateWithCallback( xBufferSizeBytes, xTriggerLevelBytes, pxSendCompletedCallback, pxReceiveCompletedCallback ) \
162-
xStreamBufferGenericCreate( xBufferSizeBytes, xTriggerLevelBytes, pdFALSE, pxSendCompletedCallback, pxReceiveCompletedCallback )
162+
xStreamBufferGenericCreate( ( xBufferSizeBytes ), ( xTriggerLevelBytes ), pdFALSE, ( pxSendCompletedCallback ), ( pxReceiveCompletedCallback ) )
163163
#endif
164164

165165
/**
@@ -253,11 +253,11 @@ typedef void (* StreamBufferCallbackFunction_t)( StreamBufferHandle_t xStreamBuf
253253
*/
254254

255255
#define xStreamBufferCreateStatic( xBufferSizeBytes, xTriggerLevelBytes, pucStreamBufferStorageArea, pxStaticStreamBuffer ) \
256-
xStreamBufferGenericCreateStatic( xBufferSizeBytes, xTriggerLevelBytes, pdFALSE, pucStreamBufferStorageArea, pxStaticStreamBuffer, NULL, NULL )
256+
xStreamBufferGenericCreateStatic( ( xBufferSizeBytes ), ( xTriggerLevelBytes ), pdFALSE, ( pucStreamBufferStorageArea ), ( pxStaticStreamBuffer ), NULL, NULL )
257257

258258
#if ( configUSE_SB_COMPLETED_CALLBACK == 1 )
259259
#define xStreamBufferCreateStaticWithCallback( xBufferSizeBytes, xTriggerLevelBytes, pucStreamBufferStorageArea, pxStaticStreamBuffer, pxSendCompletedCallback, pxReceiveCompletedCallback ) \
260-
xStreamBufferGenericCreateStatic( xBufferSizeBytes, xTriggerLevelBytes, pdFALSE, pucStreamBufferStorageArea, pxStaticStreamBuffer, pxSendCompletedCallback, pxReceiveCompletedCallback )
260+
xStreamBufferGenericCreateStatic( ( xBufferSizeBytes ), ( xTriggerLevelBytes ), pdFALSE, ( pucStreamBufferStorageArea ), ( pxStaticStreamBuffer ), ( pxSendCompletedCallback ), ( pxReceiveCompletedCallback ) )
261261
#endif
262262

263263
/**

‎include/task.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -865,9 +865,9 @@ BaseType_t xTaskDelayUntil( TickType_t * const pxPreviousWakeTime,
865865
* vTaskDelayUntil() is the older version of xTaskDelayUntil() and does not
866866
* return a value.
867867
*/
868-
#define vTaskDelayUntil( pxPreviousWakeTime, xTimeIncrement ) \
869-
{ \
870-
( void ) xTaskDelayUntil( pxPreviousWakeTime, xTimeIncrement ); \
868+
#define vTaskDelayUntil( pxPreviousWakeTime, xTimeIncrement ) \
869+
{ \
870+
( void ) xTaskDelayUntil( ( pxPreviousWakeTime ), ( xTimeIncrement ) ); \
871871
}
872872

873873

0 commit comments

Comments
 (0)