-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clipboard button on commit #1462
Conversation
Please note that https://web.dev/async-clipboard/#security-and-permissions See also https://stackoverflow.com/a/30810322 for possible workarounds. ungit uses octicon icons everywhere else so I think it would be better to use them here too. E.g. https://primer.style/octicons/clippy-16 What do you think about making the button smaller like |
@campersau actually I'm a complete n00b at KO and I'm working on the nodegit branch, this was a quick hack to get a feel for it. If you were to implement your suggestions I'd be really grateful 😅 (if not, I totally understand, I'm just saying that I wouldn't feel offended in the least if you implemented this properly, on the contrary) |
@campersau 💯 😍 |
I just wonder how to show the button when you hover over the commit message, not the commit node. That way you can quickly copy an oid from the page. |
Or just keep the button always visible regardless of mouseover? |
Hmm right, I was worrying that it adds too much visual noise |
Right now, it shows when you hover or click the commit. How can I make it also show when I just hover over the commit hash?
Should this have a test? What should it test?