Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a commit & push button #1038

Closed
ylecuyer opened this issue Feb 2, 2018 · 9 comments
Closed

Add a commit & push button #1038

ylecuyer opened this issue Feb 2, 2018 · 9 comments

Comments

@ylecuyer
Copy link
Contributor

ylecuyer commented Feb 2, 2018

I often find myself doing the combo commit & push.

I think it may be useful to have a commit & push button next to the existing commit button

@campersau
Copy link
Collaborator

Just to clarify: this should push to the currently active remote right?

Visual Studio uses this design:
7838 image_042e259b

@ylecuyer
Copy link
Contributor Author

ylecuyer commented Feb 2, 2018

Right. What does commit and sync does ?

@campersau
Copy link
Collaborator

Commit and Sync does three things. First, it will commit. Second, it will perform a pull (grabs the updated information from the remote repo). Finally, it will push.

https://stackoverflow.com/a/30039179

@jung-kim
Copy link
Collaborator

jung-kim commented Feb 3, 2018

Should one implement this, can we make this feature a simple flag that alters behavior of the commit button rather than have it as new button? I think that would be better

@ylecuyer
Copy link
Contributor Author

ylecuyer commented Feb 3, 2018 via email

@jung-kim
Copy link
Collaborator

jung-kim commented Feb 3, 2018

So when commit and push is clicked does commit button switch to commit and push button and state is managed that way? or when you want o do commit and push do you have to do two clicks all the time?

Honestly as long state is sticky I'm for it

@campersau
Copy link
Collaborator

In Visual studio it is not a sticky button but I am not sure if it should be. @jung-kim what is your definition of sticky? Sticky per session? Per repository? Global?
Two clicks are at least one click less than now 😄

Also one interesting thing is that if there is no remote Visual Studio still shows the commit and push option and displays a screen where you can add a remote after the commit.

@jung-kim
Copy link
Collaborator

jung-kim commented Feb 8, 2018

I was thinking per browser should be sufficient.

oh thats nice, we can do that as well.

@campersau
Copy link
Collaborator

fixed with #1046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants