Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancel button next to commit (amend, empty-commit) #1029

Closed
ylecuyer opened this issue Jan 28, 2018 · 3 comments
Closed

Add cancel button next to commit (amend, empty-commit) #1029

ylecuyer opened this issue Jan 28, 2018 · 3 comments

Comments

@ylecuyer
Copy link
Contributor

Add a cancel button next to the commit button in the staging view.
Currently, when you're amending a commit or committing an empty commit you have to refresh to cancel.

@jung-kim
Copy link
Collaborator

I don't understand the concept of canceling commit. A commit should be final, and if you want to go back you can go back to the commit before and rework.

@campersau
Copy link
Collaborator

If there is nothing to commit you see this:
image
In #1030 a second link will appear and it is not possible to go back to this view after you clicked on one of the links without refreshing the page.

@jung-kim
Copy link
Collaborator

Am I understanding correctly that we are adding #1028 and that implementation, #1030, now needs cancel button?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants