Add --feature readonly, to build a bin without risky commands #141
+107
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can instantiate Cli to a safe default with everything disabled. Signed-off-by: Daniel Schaefer <dhs@frame.work>
```
> cargo build --features readonly && sudo ./target/debug/framework_tool --dump-ec-flash ec.bin && ls -l ec.bin
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s
ls: cannot access 'ec.bin': No such file or directory
> cargo build && sudo ./target/debug/framework_tool --dump-ec-flash ec.bin && ls -l ec.bin
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s
Dumping to ec.bin
-rw-r--r--. 1 root root 524288 May 10 09:24 ec.bin
```
Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
readonly
branch
2 times, most recently
from
06422da to
3cda8c5
Compare
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example: