smart_battery: Allow loading battery dump from file

The --smartbattery flag now accepts an optional file path to load
previously dumped battery data instead of reading from the actual
battery. This enables offline analysis and debugging.

Signed-off-by: Daniel Schaefer <dhs@frame.work>

Author: JohnAZoidberg

Cargo.lock

@@ -1,6 +1,8 @@
 //! Module to factor out commandline interaction
 //! This way we can use it in the regular OS commandline tool on Linux and Windows,
 //! as well as on the UEFI shell tool.
+use std::path::PathBuf;
+
 use clap::error::ErrorKind;
 use clap::Parser;
 use clap::{command, Arg, Args, FromArgMatches};
@@ -49,9 +51,9 @@ struct ClapCli {
     #[arg(long)]
     power: bool,
 
-    /// Show detailed smart battery information
-    #[arg(long)]
-    smartbattery: bool,
+    /// Show detailed smart battery information, or load from dump file
+    #[arg(long, value_name = "FILE")]
+    smartbattery: Option<Option<PathBuf>>,
 
     /// Authenticate smart battery (requires unseal and auth keys)
     #[arg(long)]
@@ -415,7 +417,9 @@ pub fn parse(args: &[String]) -> Cli {
         device: args.device,
         compare_version: args.compare_version,
         power: args.power,
-        smartbattery: args.smartbattery,
+        smartbattery: args
+            .smartbattery
+            .map(|opt| opt.map(|x| x.into_os_string().into_string().unwrap())),
         smartbattery_auth: args.smartbattery_auth,
         thermal: args.thermal,
         sensors: args.sensors,

framework_lib/src/commandline/clap_std.rs

@@ -169,7 +169,7 @@ pub struct Cli {
     pub device: Option<HardwareDeviceType>,
     pub compare_version: Option<String>,
     pub power: bool,
-    pub smartbattery: bool,
+    pub smartbattery: Option<Option<String>>,
     pub smartbattery_auth: bool,
     pub thermal: bool,
     pub sensors: bool,
@@ -1502,11 +1502,26 @@ pub fn run_with_args(args: &Cli, _allupdate: bool) -> i32 {
         print_board_ids(&ec);
     } else if args.power {
         return power::get_and_print_power_info(&ec);
-    } else if args.smartbattery {
+    } else if let Some(smartbattery_arg) = &args.smartbattery {
         #[cfg(not(feature = "uefi"))]
         {
-            let bat = SmartBattery::new();
-            print_err(bat.dump_data(&ec));
+            use crate::smart_battery::{display_battery_data, BatteryData};
+            use std::path::Path;
+
+            match smartbattery_arg {
+                Some(file_path) => {
+                    // Load from file
+                    match BatteryData::read_from_file(Path::new(file_path)) {
+                        Ok(data) => display_battery_data(&data),
+                        Err(e) => eprintln!("Failed to read battery dump: {}", e),
+                    }
+                }
+                None => {
+                    // Read from actual battery
+                    let bat = SmartBattery::new();
+                    print_err(bat.dump_data(&ec));
+                }
+            }
         }
     } else if args.smartbattery_auth {
         #[cfg(not(feature = "uefi"))]

framework_lib/src/commandline/mod.rs

@@ -35,7 +35,7 @@ pub fn parse(args: &[String]) -> Cli {
         device: None,
         compare_version: None,
         power: false,
-        smartbattery: false,
+        smartbattery: None,
         smartbattery_auth: false,
         thermal: false,
         sensors: false,