Skip to content

Commit c3109e1

Browse files
committed
Make use of unified image and RocksDB as storage enginge per default in our e2e tests to reduce test variations
1 parent a7d884d commit c3109e1

File tree

2 files changed

+6
-23
lines changed

2 files changed

+6
-23
lines changed

e2e/Makefile

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -41,28 +41,11 @@ FDB_VERSION_TAG_MAPPING?=
4141
# The FEATURE_SERVER_SIDE_APPLY is enabled per default, but could be set to false if wanted.
4242
FEATURE_SERVER_SIDE_APPLY=true
4343

44-
# If the FEATURE_UNIFIED_IMAGE environment variable is not defined the test suite will be randomly enable (1) or disable (0)
45-
# the unified image feature.
46-
ifndef FEATURE_UNIFIED_IMAGE
47-
ifeq ($(shell shuf -i 0-1 -n 1), 0)
48-
FEATURE_UNIFIED_IMAGE=false
49-
else
50-
FEATURE_UNIFIED_IMAGE=true
51-
endif
52-
endif
53-
54-
# If the STORAGE_ENGINE environment variable is not defined the test suite will be randomly choosing between the ssd
55-
# storage-engine (sqlite) or RocksDB. In the future we can add more storage engines for testing here, e.g. Redwood or
56-
# sharded RocksDB.
57-
ifndef STORAGE_ENGINE
58-
ifeq ($(shell shuf -i 0-1 -n 1), 0)
59-
# Default case
60-
STORAGE_ENGINE="ssd"
61-
else
62-
STORAGE_ENGINE="ssd-rocksdb-v1"
63-
endif
64-
endif
65-
44+
# Per default the unified image is used for the e2e test cases, this can be changed by running the test suite with
45+
# FEATURE_UNIFIED_IMAGE=false.
46+
FEATURE_UNIFIED_IMAGE?=true
47+
# The default storage engine for the operator e2e tests is RocksDB.
48+
STORAGE_ENGINE?="ssd-rocksdb-v1"
6649
# If the FEATURE_SYNCHRONIZATION_MODE environment variable is not defined the test suite will be randomly enable (1) or disable (0)
6750
# the the global synchronization mode.
6851
ifndef FEATURE_SYNCHRONIZATION_MODE

e2e/fixtures/options.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ func (options *FactoryOptions) BindFlags(fs *flag.FlagSet) {
178178
fs.BoolVar(
179179
&options.featureOperatorUnifiedImage,
180180
"feature-unified-image",
181-
false,
181+
true,
182182
"defines if the operator tests should make use of the unified image.",
183183
)
184184
fs.BoolVar(

0 commit comments

Comments
 (0)