Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circles doesn't follow design guidelines #18340

Open
6 of 7 tasks
depascalis opened this issue Oct 6, 2021 · 2 comments
Open
6 of 7 tasks

Circles doesn't follow design guidelines #18340

depascalis opened this issue Oct 6, 2021 · 2 comments
Assignees

Comments

@depascalis
Copy link

depascalis commented Oct 6, 2021

Describe the bug
This is more of a question, but might be a bug.

The Icon Design Guidelines states that circles should be 15px in diameter. When looking at FA icons, all the circles I have inspected are 15.5px in diameter (eg. circle regular, circle solid, info-circle). There is probably a good reason for this so I'm curious of why that is?

I suggest clarifying the documentation on how to align the vertices on open and closed paths on the 16px grid in the design phase, and also how strokes should be aligned on shapes (inner, center, outer).

Version and implementation
Version: 5.15

  • SVG with JS
  • Web Fonts with CSS
  • SVG Sprites
  • On the Desktop

Bug report checklist

  • I have filled out as much of the above information as I can
  • I have included a test case because my odds go way up that the team can fix this when I do
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
@tagliala
Copy link
Member

tagliala commented Oct 6, 2021

Hi!

Thanks for being part of the Font Awesome Community and thanks for reporting this.

Good question, let's ask @sensibleworld

@sensibleworld
Copy link
Member

Yup! Those docs need updating. I'm putting it on my to-do list. With version 6, our circles are all sized at 16px. With version 5, they were 15.5px... but something must have gotten lost in translation when we were first writing the docs.

@sensibleworld sensibleworld self-assigned this Oct 13, 2021
@tagliala tagliala added the doc label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants