-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility issue with HTML icon: "i" tag used to format text #16790
Comments
Hi! Thanks for being part of the Font Awesome Community.
I personally agree with you, but I should point out that the first page and first paragraph of our documentation clearly states that Quote:
Emphasis mine Ref: https://fontawesome.com/how-to-use/on-the-web/referencing-icons/basic-use Hope it helps Closing here |
I would like to reopen this issue as it has not been resolved. As you pointed out, the documentation says that the
By choosing brevity, we are saying that the following are not important and don't need to be followed:
Edit: This is the location of the Please advise, thank you. |
@robmadole @talbs any second thoughts on this? I've always been in favor of |
@pat-kavanagh I appreciate you posting. Here are my thoughts: While I think that a My question is if "bad practice" translates to the One thing we might consider is updating the accessibility page to mention that using a |
Hey Rob, Thanks for the response. I totally understand your concern about legacy code. It can definitely become an issue when it comes to adding new features, but I would consider WCAG support exactly that. A new feature. For a company like Font Awesome that is continually adding great new features, I have full faith in your team's ability to increase WCAG support! Also, in looking at a version of Font Awesome 1, there are actually no references to an While the documentation discusses using span tags as @tagliala quoted above, if we're going to be honest, developers don't typically take the time to read through all of a library's docs. They would trust that the information provided by a library, like Font Awesome, in its examples would be following its own semantic documentation. For the discussion around the In doing some research on other icon libraries, Bootstrap changed their approach from using the If we need to continue legacy support for the I appreciate your time on this matter, please let me know your thoughts. Thank you! |
Font Awesome was born as a replacement of glyphicons for Bootstrap You can see the use of That's why Font Awesome used About span and accessibility, correct me if I'm wrong: turning Another question: does the tool in the first post show an issue for |
Agree. Automated accessibility checkers (like Wave, Siteimprove, etc.) mark every instance of |
Hi @tagliala, That is great to know about the origins of Font Awesome, I was unaware! If Bootstrap glyphicons were the inspiration of Font Awesome and the reason the
If we can change the i tag + aria-hidden='true' @kdmarks, I see from your LinkedIn that you are an accessibility specialist. I would love to hear more of your thoughts on this issue if I am missing anything! Thank you for the ongoing discussion! |
Ok. I'll get with @davegandy and @supercodepoet on this and we'll see if this is something version 6 needs to address. Thanks everyone for the great information. That will help a great deal as we discuss. |
Thank you @robmadole & @tagliala! Please let me know if there's anything else I can do to help, I appreciate your consideration on this issue! |
tl;dr SonarCloud reports this as an issue also. The solution is to add
We noticed this and fixed it ourselves, but would be beneficial to add it to the documentation. |
@pat-kavanagh I am unable to reproduce this error with Siteimprove's Chrome extension or through their site. Can you provide reproduction steps please? |
@robmadole Steps to reproduce:
|
And here is SonarCloud's rule which as @OssiPesonen mentioned is relaxed if |
Hello Font-Awesome,
On each Font Awesome icon page, it shows an HTML example of how to use the icon. For example,
<i class="fa fa-plus"></i>
The current implementation of using the
<i>
tag does not meet accessibility standards as shown from the Siteimprove page scan attached and should be resolved immediately. If we used a<span>
tag or another similar inline element it would be much more accessible. This is the greatest icon resource available online and it would be great to see it move in a more WCAG compliant direction.Thank you!
The text was updated successfully, but these errors were encountered: