Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribution Comments Missing from SVGs? #15580

Closed
3 of 4 tasks
GuyPaddock opened this issue Sep 20, 2019 · 4 comments
Closed
3 of 4 tasks

Attribution Comments Missing from SVGs? #15580

GuyPaddock opened this issue Sep 20, 2019 · 4 comments

Comments

@GuyPaddock
Copy link

Describe the bug
According to the documentation:

Downloaded Font Awesome Free files already contain embedded comments with sufficient attribution, so you shouldn't need to do anything additional when using these files normally.

But, looking at SVGs like user.svg or building.svg there's no comment at all in the SVG with the attribution.

To Reproduce
Open the raw SVG content for an icon.

Expected behavior
The SVG should contain a comment with attribution, as indicated in the docs.

Version and implementation
Version: 5.x

  • SVG Sprites

Bug report checklist

  • I have filled out as much of the above information as I can
  • I have included a test case because my odds go way up that the team can fix this when I do
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
@apennell
Copy link

Plus one on this! I'm trying to figure out how to properly give attribute to the svg but so far haven't been able to find how to do that. I'm not plopping the file straight in my code, I'm using the path and viewBox for a dynamic Icon component. Is it ok if I put something like this at the top of the files?:

/**
 * Adapted from Font Awesome arrow-right: https://fontawesome.com/icons/arrow-right?style=solid,
 * which is licensed under the Creative Commons Attribution 4.0 International license:
 * https://creativecommons.org/licenses/by/4.0/
 */

@tagliala
Copy link
Member

tagliala commented Sep 12, 2020

@robmadole I remember we already have discussed the attribution when using individual .svg files, but at the moment I'm not able to find the original question

Any chance to clarify one more time?

@cozimacode
Copy link

Same here. Any comment from official FA team would be great. Could we add the comment our self as mentioned by @apennell ?

@tagliala
Copy link
Member

tagliala commented Mar 2, 2021

This has been fixed in version 5.15.0

<!--
Font Awesome Free 5.15.0 by @fontawesome - https://fontawesome.com
License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License)
-->

Closing here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants