Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cornerRadius prop for VictoryBar #705

Closed
ricardoalvarenga101 opened this issue Aug 8, 2017 · 2 comments · Fixed by FormidableLabs/victory-core#316
Closed

Add cornerRadius prop for VictoryBar #705

ricardoalvarenga101 opened this issue Aug 8, 2017 · 2 comments · Fixed by FormidableLabs/victory-core#316

Comments

@ricardoalvarenga101
Copy link

ricardoalvarenga101 commented Aug 8, 2017

Is possible Corner Rounded in Victory Bar?

@ricardoalvarenga101 ricardoalvarenga101 changed the title Victory Bar - Radius? Victory Bar - Rounded? Aug 8, 2017
@ricardoalvarenga101 ricardoalvarenga101 changed the title Victory Bar - Rounded? Victory Bar - Corner Rounded? Aug 8, 2017
@boygirl
Copy link
Contributor

boygirl commented Aug 9, 2017

right now there isn't a simple way to make rounded bars, but you can hack something together with styles. Try adding strokeLinejoin: "round", strokeWidth: 6 to your bar styles. I'll also look into adding a cornerRadius prop for VictoryBar

@boygirl boygirl changed the title Victory Bar - Corner Rounded? Add cornerRadius prop for VictoryBar Aug 9, 2017
@mindjuice
Copy link

Drive-by comment. I currently have no use for this, but if I did, I imagine would only want the top corners rounded for positive values and the bottom corners rounded for negative values. There would also be the case of a stacked graph to consider (and possibly ignore) where the interior bars stay square and the exterior one gets rounded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants