-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persistent Hover Accessibility Guideline #2088
Comments
@jpc98 This issue looks like it can be solved by nesting your data inside a <VictoryChart domainPadding={{ y: 10, x: 20 }}
containerComponent={
<VictoryVoronoiContainer/>
}
>
<VictoryBar
data={sampleData}
labels={() => "HELLO"}
labelComponent={
<VictoryTooltip
center={{ x: 225, y: 30 }}
pointerOrientation="bottom"
flyoutWidth={150}
flyoutHeight={50}
pointerWidth={150}
cornerRadius={0}
/>
}
/>
</VictoryChart> |
Thanks for the suggested solution! This feels more like a workaround to me, and it may be worth considering making this feature standard for victory's tooltips rather than relying on consumers to implement a VoronoiContainer for the tooltips to meet the standard. But definitely lower priority since there's a way around it! |
I wonder if it may be best to control this behavior with a prop, maybe something like a |
Maybe an override would make sense, but I do think we'd want the default to be meeting the accessibility guideline if at all possible, since that's the reason that guideline exists in the first place! The tooltip vanishing may be desired behavior, but it's also a problematic behavior for users using certain kinds of assistive technology. That said, I realize this is the sort of change that could lead to a worse experience for certain use cases, so an override of some sort would make sense as long as the accessibility implications were documented. That way the site still behaves as originally intended until a more accessible design can be implemented without making the application difficult to use. |
Feature Requests
Checklist
I've read through the Docs and Guides to make sure this functionality doesn't already exist
I've searched open issues to make sure I'm not opening a duplicate issue
Description
The WCAG guidelines have the following criteria for hover bubbles:
https://www.w3.org/TR/WCAG21/#content-on-hover-or-focus
Relevant text quoted below:
This is not met by the hover tooltips provided by VictoryChart currently - when hovering over the content that pops up, the content disappears since the user is no longer hovering over the relevant point.
The text was updated successfully, but these errors were encountered: