We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is not a victory-native specific issue. (Issues that only appear in victory-native should be opened here)
victory-native
I have read through the FAQ and Guides before asking a question
I am using the latest version of Victory
I've searched open issues to make sure I'm not opening a duplicate issue
When providing a backgroundStyle prop to VictoryLabel, the functional styles are not being passed props for evaluation.
backgroundStyle
VictoryLabel
This sandbox shows the problem: https://codesandbox.io/s/basic-victory-example-eck0o?file=/index.js
Open console to see that undefined is returned when logging the argument provided to the fill functional style.
undefined
fill
I believe this is due to the following code:
victory/packages/victory-core/src/victory-label/victory-label.js
Lines 77 to 80 in cc9b9b2
On line 79, props are missing as the second argument to Helpers.evaluateStyle.
props
Helpers.evaluateStyle
If you agree with my findings, I would be happy to create a PR altering this one line.
The text was updated successfully, but these errors were encountered:
@chacestew Good catch! Your solution is correct, and a PR would be very welcome. Thank you!
Sorry, something went wrong.
No branches or pull requests
Bugs and Questions
Checklist
This is not a
victory-native
specific issue. (Issues that only appear invictory-native
should be opened here)I have read through the FAQ and Guides before asking a question
I am using the latest version of Victory
I've searched open issues to make sure I'm not opening a duplicate issue
The Problem
When providing a
backgroundStyle
prop toVictoryLabel
, the functional styles are not being passed props for evaluation.Reproduction
This sandbox shows the problem: https://codesandbox.io/s/basic-victory-example-eck0o?file=/index.js
Open console to see that
undefined
is returned when logging the argument provided to thefill
functional style.Cause
I believe this is due to the following code:
victory/packages/victory-core/src/victory-label/victory-label.js
Lines 77 to 80 in cc9b9b2
On line 79,
props
are missing as the second argument toHelpers.evaluateStyle
.Fix
If you agree with my findings, I would be happy to create a PR altering this one line.
The text was updated successfully, but these errors were encountered: