Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Victorybar should have an option for vertically aligning the VictoryLabel within each bar #1537

Open
2 tasks done
repl-ullas-ml opened this issue Apr 27, 2020 · 2 comments
Open
2 tasks done

Victorybar should have an option for vertically aligning the VictoryLabel within each bar #1537

repl-ullas-ml opened this issue Apr 27, 2020 · 2 comments
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release

Comments

@repl-ullas-ml
Copy link

repl-ullas-ml commented Apr 27, 2020 •
edited
Loading

Feature Requests

Checklist

  • I've read through the Docs and Guides to make sure this functionality doesn't already exist

  • I've searched open issues to make sure I'm not opening a duplicate issue

Description

VictoryBar doesnt offer us a way to vertically align the text as part of the bar.
VictoryLabel provides a dy but we have no means to compute half the size of the bar

Screen Shot 2020-04-27 at 1 26 01 PM

Screen Shot 2020-04-27 at 7 32 49 PM
@narinluangrath narinluangrath added the Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release label May 3, 2020
@narinluangrath
Copy link
Contributor

Similar to issue #1440

@milotoor
Copy link

milotoor commented Feb 4, 2021

In case anyone finds themselves here in search of a resolution, see my comment on #1440 about how I solved this for tooltips. Note that the same approach will not work for labels, because VictoryLabel is a simple functional component while VictoryTooltip is a class component.

@carbonrobot carbonrobot added the Issue: Accepted The submitted issue has been confirmed by the Victory core team label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@carbonrobot @milotoor @repl-ullas-ml @narinluangrath