Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Yarn PnP #1495

Closed
Mike-Dax opened this issue Mar 2, 2020 · 0 comments · Fixed by #1496
Closed

Incompatible with Yarn PnP #1495

Mike-Dax opened this issue Mar 2, 2020 · 0 comments · Fixed by #1496

Comments

@Mike-Dax
Copy link
Contributor

Mike-Dax commented Mar 2, 2020

The Problem

Victory charts is incompatible with Yarn PnP due to out of spec imports.

For example, victory-voronoi-container imports react-fast-compare but it is not declared in victory-voronoi-containers package.json.

This currently works for other package managers due to how the node_modules folders just happen to be mounted, but this should be considered undefined behavior.

Reproduction

Install victory into a project with Yarn PnP enabled.

Description

I've opened a PR to fix this immediate issue, it would be nice if yarn PnP installs were added to any CI tests that are being done to catch these kinds of issues.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant