Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: FormidableLabs/spectacle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: spectacle@10.2.1
Choose a base ref
...
head repository: FormidableLabs/spectacle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: spectacle@10.2.2
Choose a head ref
  • 4 commits
  • 13 files changed
  • 3 contributors

Commits on Sep 25, 2025

  1. fix: resolve React 19 compatibility by replacing defaultProps with at…

    …trs (#1351)
    
    ### Description
    
    This PR fixes React 19 compatibility issues in Spectacle by replacing all usage of the deprecated `defaultProps` pattern with styled-components' `attrs` method. 
    
    React 19 removed support for `defaultProps` on function components, which was breaking components throughout the Spectacle codebase. While the issue was initially reported for the FullScreen component, investigation revealed that many other components (typography, table, and layout primitives) were also affected.
    
    The solution follows the [recommended approach from styled-components](styled-components/styled-components#3967) using the `attrs` method with function variant syntax, which allows props to override defaults while maintaining full backward compatibility.
    
    **Key Changes:**
    - Replaced `defaultProps` with `styled.component.attrs((props) => ({ ...defaults, ...props }))` pattern
    - Fixed typography components: Text, Heading, Quote, OrderedList, UnorderedList, ListItem, Link, CodeSpan, ScalableText
    - Fixed table components: Table, TableHeader, TableBody, TableRow, TableCell  
    - Fixed layout components: FlexBox, Grid
    - Maintained all existing functionality and APIs
    - Ensured props can still override defaults
    
    Fixes #1350
    umxr authored Sep 25, 2025
    Configuration menu
    Copy the full SHA
    ac05838 View commit details
    Browse the repository at this point in the history
  2. Update OIDC and node versions (#1355)

    - Update release action to use NPM OIDC. This work is modeled on @zibs work in https://github.com/FormidableLabs/victory-native-xl/pull/619/files
        - Note: OIDC connect has been set up in NPM for spectacle, spectacle-mdx-loader, and create-spectacle.
    - Update CI to use Node 22.x
    ryan-roemer authored Sep 25, 2025
    Configuration menu
    Copy the full SHA
    0452103 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2025

  1. Configuration menu
    Copy the full SHA
    5d95275 View commit details
    Browse the repository at this point in the history
  2. Version Packages (#1354)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions[bot] authored Sep 26, 2025
    Configuration menu
    Copy the full SHA
    43a0d14 View commit details
    Browse the repository at this point in the history
Loading