Skip to content

Commit 73f619e

Browse files
committed
Merge pull request tzutalin#12 from DevFactory/release/utility-classes-should-not-have-public-constructors-fix-1
squid:S1118 - Utility classes should not have public constructors
2 parents 85a60da + e6caa3d commit 73f619e

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

cnnlibs/src/main/java/com/tzutalin/vision/visionrecognition/Utils.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,12 @@
2929
/**
3030
* Created by darrenl on 2015/9/10.
3131
*/
32-
public class Utils {
32+
public final class Utils {
33+
34+
private Utils() throws InstantiationException {
35+
throw new InstantiationException("This class is not for initialization");
36+
}
37+
3338
@NonNull
3439
public static Map<String, Float> sortPrediction(@NonNull String[] synsets, @NonNull float[] propArray) {
3540
HashMap<String, Float> map = new HashMap<>();

cnnlibs/src/main/java/com/tzutalin/vision/visionrecognition/VisionClassifierCreator.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
/**
2525
* Create an instance using default instances for vision recognition and detection
2626
*/
27-
public class VisionClassifierCreator {
27+
public final class VisionClassifierCreator {
2828
private final static String SCENE_MODEL_PATH = "/sdcard/vision_scene/mit/deploy_places205_mem.protxt";
2929
private final static String SCENE_WIEGHTS_PATH = "/sdcard/vision_scene/mit/googlelet_places205_train_iter_2400000.caffemodel";
3030
private final static String SCENE_MEAN_FILE = null;
@@ -35,6 +35,10 @@ public class VisionClassifierCreator {
3535
private final static String DETECT_MEAN_FILE = "/sdcard/fastrcnn/imagenet_mean.binaryproto";
3636
private final static String DETECT_SYNSET_FILE = "/sdcard/fastrcnn/fastrcnn_synset";
3737

38+
private VisionClassifierCreator() throws InstantiationException {
39+
throw new InstantiationException("This class is not for instantiation");
40+
}
41+
3842
/**
3943
* Create an instance using a default {@link SceneClassifier} instance
4044
* @return {@link SceneClassifier instance

0 commit comments

Comments
 (0)