squid:S00117, squid:S1854 - Local variable and method parameter names should comply with a naming convention, Dead stores should be removed

Author: Mohammed Ezzat

app/src/main/java/com/tzutalin/vision/demo/Camera2BasicFragment.java

@@ -755,7 +755,7 @@ private void captureStillPicture() {
             int rotation = activity.getWindowManager().getDefaultDisplay().getRotation();
             captureBuilder.set(CaptureRequest.JPEG_ORIENTATION, ORIENTATIONS.get(rotation));
 
-            CameraCaptureSession.CaptureCallback CaptureCallback
+            CameraCaptureSession.CaptureCallback captureCallback
                     = new CameraCaptureSession.CaptureCallback() {
 
                 @Override
@@ -782,7 +782,7 @@ public void onCaptureCompleted(@NonNull CameraCaptureSession session,
             };
 
             mCaptureSession.stopRepeating();
-            mCaptureSession.capture(captureBuilder.build(), CaptureCallback, null);
+            mCaptureSession.capture(captureBuilder.build(), captureCallback, null);
         } catch (CameraAccessException e) {
             e.printStackTrace();
         }

app/src/main/java/com/tzutalin/vision/demo/ObjectDetectActivity.java

@@ -95,8 +95,8 @@ protected void onPreExecute() {
         @Override
         protected List<VisionDetRet> doInBackground(String... strings) {
             final String filePath = strings[0];
-            long startTime = 0;
-            long endTime = 0;
+            long startTime;
+            long endTime;
             Log.d(TAG, "DetectTask filePath:" + filePath);
             if (mObjectDet == null) {
                 try {

app/src/main/java/com/tzutalin/vision/demo/SceneRecognitionActivity.java

@@ -124,8 +124,8 @@ protected void onPreExecute() {
         @Override
         protected List<VisionDetRet> doInBackground(String... strings) {
             initCaffeMobile();
-            long startTime = 0;
-            long endTime = 0;
+            long startTime;
+            long endTime;
             final String filePath = strings[0];
             List<VisionDetRet> rets = new ArrayList<>();
             Log.d(TAG, "PredictTask filePath:" + filePath);

cnnlibs/src/main/java/com/tzutalin/vision/visionrecognition/SceneClassifier.java

@@ -78,11 +78,11 @@ public List<VisionDetRet> classifyByPath(String imgPath) {
         float[] propArray = jniClassifyImgByPath(imgPath);
         if (propArray != null) {
             Map<String, Float> sortedmap = Utils.sortPrediction(mSynsets, propArray);
-            int k_size = 10;
+            int kSize = 10;
             for (String key : sortedmap.keySet()) {
                 VisionDetRet det = new VisionDetRet(key, sortedmap.get(key), 0, 0, 0, 0);
                 ret.add(det);
-                if (k_size == ret.size())
+                if (kSize == ret.size())
                     break;
             }
         }
@@ -114,11 +114,11 @@ public List<VisionDetRet> classify(Bitmap bitmap) {
         float[] propArray = jniClassifyBitmap(_handler);
         if (propArray != null) {
             Map<String, Float> sortedmap = Utils.sortPrediction(mSynsets, propArray);
-            int k_size = 10;
+            int kSize = 10;
             for (String key : sortedmap.keySet()) {
                 VisionDetRet det = new VisionDetRet(key, sortedmap.get(key), 0, 0, 0, 0);
                 ret.add(det);
-                if (k_size == ret.size())
+                if (kSize == ret.size())
                     break;
             }
         }