chore: lint

Author: matthv

src/datasource_toolkit/forestadmin/datasource_toolkit/interfaces/query/filter/factory.py

@@ -46,7 +46,6 @@ def __replace(leaf: ConditionTree) -> ConditionTree:
             time_transform = time_transforms(1)
             if leaf.operator not in SHIFTED_OPERATORS:
                 return leaf
-                raise FilterFactoryException(f"'{leaf.operator}' is not shiftable ")
 
             alternative: Alternative = time_transform[leaf.operator][0]
             leaf = alternative["replacer"](leaf, tz)

src/datasource_toolkit/tests/interfaces/query/filter/test_factory.py

@@ -45,16 +45,12 @@
 )
 
 
-@mock.patch(
-    "forestadmin.datasource_toolkit.interfaces.query.filter.factory.time_transforms"
-)
+@mock.patch("forestadmin.datasource_toolkit.interfaces.query.filter.factory.time_transforms")
 def test_shift_period_filter(mock_time_transform: mock.MagicMock):
     shift_period_filter_replacer = FilterFactory._shift_period_filter("UTC")  # type: ignore
     leaf = ConditionTreeLeaf(field="test", operator=Operator.PREVIOUS_YEAR)
     mock_replacer = mock.MagicMock(return_value="fake_replacer")
-    mock_time_transform.return_value = {
-        Operator.PREVIOUS_YEAR: [{"replacer": mock_replacer}]
-    }
+    mock_time_transform.return_value = {Operator.PREVIOUS_YEAR: [{"replacer": mock_replacer}]}
     with mock.patch(
         "forestadmin.datasource_toolkit.interfaces.query.filter.factory.SHIFTED_OPERATORS",
         {Operator.PREVIOUS_YEAR},
@@ -70,35 +66,23 @@ def test_shift_period_filter(mock_time_transform: mock.MagicMock):
         assert shift_period_filter_replacer(leaf) == leaf
 
 
-@mock.patch(
-    "forestadmin.datasource_toolkit.interfaces.query.filter.factory.time_transforms"
-)
+@mock.patch("forestadmin.datasource_toolkit.interfaces.query.filter.factory.time_transforms")
 def test_shift_period_filter_with_complex_condition_tree(
     mock_time_transform: mock.MagicMock,
 ):
     tz = zoneinfo.ZoneInfo("UTC")
     shift_period_filter_replacer = FilterFactory._shift_period_filter(tz)
 
-    leaf_previous_year = ConditionTreeLeaf(
-        field="date_field", operator=Operator.PREVIOUS_YEAR
-    )
+    leaf_previous_year = ConditionTreeLeaf(field="date_field", operator=Operator.PREVIOUS_YEAR)
     leaf_equal = ConditionTreeLeaf(field="name", operator=Operator.EQUAL, value="test")
-    leaf_greater_than = ConditionTreeLeaf(
-        field="age", operator=Operator.GREATER_THAN, value=18
-    )
-    leaf_previous_month = ConditionTreeLeaf(
-        field="created_at", operator=Operator.PREVIOUS_MONTH
-    )
+    leaf_greater_than = ConditionTreeLeaf(field="age", operator=Operator.GREATER_THAN, value=18)
+    leaf_previous_month = ConditionTreeLeaf(field="created_at", operator=Operator.PREVIOUS_MONTH)
 
     mock_replacer_year = mock.MagicMock(
-        return_value=ConditionTreeLeaf(
-            field="date_field", operator=Operator.EQUAL, value="replaced_year"
-        )
+        return_value=ConditionTreeLeaf(field="date_field", operator=Operator.EQUAL, value="replaced_year")
     )
     mock_replacer_month = mock.MagicMock(
-        return_value=ConditionTreeLeaf(
-            field="created_at", operator=Operator.EQUAL, value="replaced_month"
-        )
+        return_value=ConditionTreeLeaf(field="created_at", operator=Operator.EQUAL, value="replaced_month")
     )
 
     mock_time_transform.return_value = {
@@ -133,22 +117,16 @@ def test_shift_period_filter_with_complex_condition_tree(
             field="date_field", operator=Operator.EQUAL, value="replaced_year"
         )
         assert result.conditions[1] == leaf_equal  # EQUAL should remain unchanged
-        assert (
-            result.conditions[2] == leaf_greater_than
-        )  # GREATER_THAN should remain unchanged
+        assert result.conditions[2] == leaf_greater_than  # GREATER_THAN should remain unchanged
         assert result.conditions[3] == ConditionTreeLeaf(
             field="created_at", operator=Operator.EQUAL, value="replaced_month"
         )
 
 
-@mock.patch(
-    "forestadmin.datasource_toolkit.interfaces.query.filter.factory.FilterFactory._shift_period_filter"
-)
+@mock.patch("forestadmin.datasource_toolkit.interfaces.query.filter.factory.FilterFactory._shift_period_filter")
 def test_get_previous_period_filter(mock_shifted_period: mock.MagicMock):
     leaf = ConditionTreeLeaf(field="test", operator=Operator.PREVIOUS_MONTH)
-    filter = Filter(
-        {"condition_tree": leaf, "timezone": zoneinfo.ZoneInfo("Europe/Paris")}
-    )
+    filter = Filter({"condition_tree": leaf, "timezone": zoneinfo.ZoneInfo("Europe/Paris")})
     with mock.patch.object(filter, "override") as override_mock:
         with mock.patch.object(leaf, "replace") as replace_override:
             override_mock.return_value = "fake_override"
@@ -220,18 +198,10 @@ async def test_make_through_filter():
                     )
 
                 assert res.condition_tree.aggregator == Aggregator.AND
-                assert (
-                    ConditionTreeLeaf("child_id", Operator.EQUAL, "fake_value")
-                    in res.condition_tree.conditions
-                )
-                assert (
-                    ConditionTreeLeaf("parent_id", Operator.IN, [1])
-                    in res.condition_tree.conditions
-                )
+                assert ConditionTreeLeaf("child_id", Operator.EQUAL, "fake_value") in res.condition_tree.conditions
+                assert ConditionTreeLeaf("parent_id", Operator.IN, [1]) in res.condition_tree.conditions
 
-                mock_get_value.assert_called_once_with(
-                    mocked_caller, collection, [1], "id"
-                )
+                mock_get_value.assert_called_once_with(mocked_caller, collection, [1], "id")
                 mock_get_value.reset_mock()
 
                 # test with unnestable PaginatedFilter
@@ -244,9 +214,7 @@ async def test_make_through_filter():
                 )
 
                 fake_datasource = mock.MagicMock()
-                fake_datasource.get_collection = mock.MagicMock(
-                    return_value=fake_collection
-                )
+                fake_datasource.get_collection = mock.MagicMock(return_value=fake_collection)
                 collection._datasource = fake_datasource  # type: ignore
 
                 mock_make_foreign_filter.reset_mock()
@@ -269,9 +237,7 @@ async def test_make_through_filter():
                             }
                         ),
                     )
-                mock_get_value.assert_called_once_with(
-                    mocked_caller, collection, [1], "id"
-                )
+                mock_get_value.assert_called_once_with(mocked_caller, collection, [1], "id")
                 fake_datasource.get_collection.assert_called_once_with("parent")  # type: ignore
                 mock_make_foreign_filter.assert_called_once_with(
                     mocked_caller,
@@ -293,9 +259,7 @@ async def test_make_through_filter():
                         "condition_tree": ConditionTreeBranch(
                             Aggregator.AND,
                             conditions=[
-                                ConditionTreeLeaf(
-                                    "child_id", Operator.EQUAL, "fake_value"
-                                ),
+                                ConditionTreeLeaf("child_id", Operator.EQUAL, "fake_value"),
                                 ConditionTreeLeaf(
                                     "parent_id",
                                     Operator.IN,