Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBUDDY_EXTERNAL_GROCY_URL not working properly #230

Open
Teslamancer opened this issue Jan 15, 2024 · 2 comments
Open

BBUDDY_EXTERNAL_GROCY_URL not working properly #230

Teslamancer opened this issue Jan 15, 2024 · 2 comments

Comments

@Teslamancer
Copy link

Teslamancer commented Jan 15, 2024

I have Barcode Buddy running in a k3s home cluster and am trying to set the external url so that the header link will work properly. As specified in the documentation, I have set the environment variable BBUDDY_EXTERNAL_GROCY_URL to my external URL "https://example.website.us/" I have also set BBUDDY_OVERRIDDEN_USER_CONFIG to use the internal k8s service for grocy, with a value like "GROCY_API_URL=http://grocy:8080/api/;GROCY_API_KEY=$(GROCY_API_KEY)" and that seems to be working properly, but the external URL in the header is set to "http://grocy:8080" despite the external url config. My helm chart is as below:

apiVersion: apps/v1 kind: Deployment metadata: name: {{ include "grocy.fullname" . }}-barcode-buddy namespace: {{ .Release.Namespace }} labels: app: barcode-buddy spec: selector: matchLabels: app: barcode-buddy template: metadata: labels: app: barcode-buddy spec: containers: - image: {{ .Values.barcodebuddy.image.repository}}:{{ .Values.barcodebuddy.image.tag }} name: barcode-buddy env: - name: GROCY_API_KEY value: {{ .Values.barcodebuddy.config.env.GROCY_API_KEY }} - name: BBUDDY_OVERRIDDEN_USER_CONFIG value: {{ .Values.barcodebuddy.config.env.BBUDDY_OVERRIDDEN_USER_CONFIG }} - name: TZ value: {{ .Values.barcodebuddy.config.env.TZ | default "UTC" }} - name: BBUDDY_EXTERNAL_GROCY_URL value: {{ .Values.barcodebuddy.config.env.BBUDDY_EXTERNAL_GROCY_URL | quote }} - name: ATTACH_BARCODESCANNER value: {{ .Values.barcodebuddy.config.env.ATTACH_BARCODESCANNER | quote }} ports: - name: http containerPort: 80 protocol: TCP volumeMounts: - mountPath: "/config" name: bbuddy-config imagePullPolicy: {{ .Values.barcodebuddy.image.pullPolicy }} volumes: - name: bbuddy-config persistentVolumeClaim: claimName: {{ .Values.barcodebuddy.persistence.existingVolumeClaim | default "barcodebuddy-config" }}

@Teslamancer
Copy link
Author

@Forceu Is there something wrong with my configuration, or is there a bug in the code?

@disconn3ct
Copy link

"Same here"

The override config works and directs it to http://grocy/api but the external URL is not used. The grocy link (and 'create product' etc) all lead to the internal address.

image: f0rc3/barcodebuddy:v1.8.1.8
env:                                                                                                                                                                              
  - name: BBUDDY_DISABLE_AUTHENTICATION                                                                                                                                             
    value: "true"
  - name: BBUDDY_EXTERNAL_GROCY_URL   
    value: https://grocy.EXAMPLE.COM/
  - name: BBUDDY_OVERRIDDEN_USER_CONFIG
    # BBUDDY_OVERRIDDEN_USER_CONFIG="GROCY_API_URL=http://grocy/api/;GROCY_API_KEY=foo" 
    valueFrom:
      secretKeyRef:
        key: config
        name: barcodeconfig
  - name: BBUDDY_TRUSTED_PROXIES
    value: 10.0.0.0/8
  - name: PGID
    value: "1000"
  - name: PUID
    value: "1000"
  - name: TZ
    value: America/New_York

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants