Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

Graceful error handling for cert expiration #2242

Closed
EnsignPayton opened this issue Oct 6, 2022 · 1 comment · Fixed by #2243
Closed

Graceful error handling for cert expiration #2242

EnsignPayton opened this issue Oct 6, 2022 · 1 comment · Fixed by #2243
Labels
audio cert HTTPS certificate failure when fetching remote audio

Comments

@EnsignPayton
Copy link

Yomichan suddenly stopped adding audio to my cards today. This is due to JapanesePod101's SSL cert expiring, which has been reported many times already:

#180 #280 #471 #676 #1216

I'm aware it's a transient issue, users are free to select an alternate audio source, etc. My suggestion is since this is a reoccurring issue, it should be handled with some visible error state to inform the user that something is wrong, and perhaps offer the suggestions of changing audio sources, waiting a day, etc.

I'm sure I'm not the only one over the past few years that made several cards only to find that none of them had audio after the fact, with no indication that anything was wrong on the Yomichan side.

@toasted-nutbread toasted-nutbread added the audio cert HTTPS certificate failure when fetching remote audio label Oct 6, 2022
@EnsignPayton
Copy link
Author

Wow that was fast, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
audio cert HTTPS certificate failure when fetching remote audio
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants