Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

Popup having suboptimal position on websites with specific layouts #2124

Closed
ChaseOxide opened this issue Apr 27, 2022 · 1 comment · Fixed by #2135
Closed

Popup having suboptimal position on websites with specific layouts #2124

ChaseOxide opened this issue Apr 27, 2022 · 1 comment · Fixed by #2135

Comments

@ChaseOxide
Copy link

Description
Happens when:

  • (horizontal-tb) start of term at the bottom, ends at the top
  • (vertical-rl) start of term at the left, ends at the right

It can be reproduced if the website uses column layouts.

My reproduction:

<div id="data" style="height: 600px; column-width: 100px; width: 300px">
</div>
<script>
  data.textContent = Array(100).fill('こんにちは。').join('')
</script>

Tiny screen (500x624)
image

Larger screen
image

Browser version
Brave 1.37 (Chromium 100)

Yomichan version
Yomichan 22.4.4.0

@toasted-nutbread
Copy link
Collaborator

#2135 makes some internal improvements to make this edge case handled a bit better. There is still potentially some room for improvement (which is more complex), but this is how it should look now (depending on popup size settings):

image
Cursor was down here ^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants