Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds one-line adjoint definitions for
ForwardDiff.gradient
andForwardDiff.jacobian
, usingforwarddiff
. This is a simpler version of what was proposed in #769.Perhaps ideally, calling Zygote over ForwardDiff would actually do reverse mode over forward mode. The proposal in #769 was in fact to turn that into forward over reverse, while this PR is forward over forward. Maybe there are cases where one is much better than the other?
But it doesn't work at all right now. Errors involved are, BTW, these:
Closes #305 (gradient of a function containing
Zygote.forward_jacobian
, replace withForwardDiff.jacobian
) and maybe #953 (gradient of a function containingjacobian
, could perhaps useForwardDiff.jacobian
).