Use _pullback inside rules instead of pullback
#1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will give us more flexibility to implement internal changes such as #603 without changing the user-facing API.
ToucheSir
commented
Mar 5, 2023
| @@ -279,7 +279,10 @@ end | |||
| enumerate(xs), back | |||
| end | |||
|
|
|||
| @adjoint Iterators.Filter(f, x) = pullback(filter, f, collect(x)) | |||
| function _pullback(cx::AContext, ::Type{<:Iterators.Filter}, f, x) | |||
There was a problem hiding this comment.
Note on why these are _pullback instead of @adjoint: @adjoint tries to do some clever postprocessing of the pullback return which results in mismatched results (differential arg tuple off by one). Using _pullback is slightly more code and requires a bit more care, but it removes a few layers from the call stack and brings us closer to removing @adjoint completely.
There was a problem hiding this comment.
Yes, when Miha and I were trying to get rid of Zygote's own types we likewise removed some uses of @adjoint and wrote the _pullback overloads directly
oxinabox
approved these changes
Mar 7, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will give us more flexibility to implement internal changes such as #603 without changing the user-facing API.