Handle ChainRulesCore.NotImplemented
#1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test error with Julia nightly seems unrelated. |
CarloLucibello
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return
nothinginstead ofChainRulesCore.NotImplemented, similar to e.g.ChainRules.AbstractZero.While this means - once again - dropping information present in CR types and hence makes the type less useful when used together with Zygote, it fixes problems such as #1204 that occur because Zygote pullbacks do not handle
NotImplemented.nothing, however, is already supported throughout Zygote.Fixes #1204.