Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all adjoints to rrules #1209

Open
ToucheSir opened this issue Apr 20, 2022 · 3 comments
Open

Convert all adjoints to rrules #1209

ToucheSir opened this issue Apr 20, 2022 · 3 comments
Labels
ChainRules adjoint -> rrule, and further integration enhancement New feature or request good first issue Good for newcomers up for grabs anyone is welcome to contribute with a PR to fix the issue
Milestone
v0.7.0

Comments

@ToucheSir
Copy link
Member

ToucheSir commented Apr 20, 2022 •
edited
Loading

We have ZygoteRuleConfig for this, so there should be no major technical limitations. rrules generally have far better UX than @adjoints (as anyone who has had to read a stacktrace from Zygote can attest). The ultimate end goal would be to get rid of ZygoteRules entirely.
@ToucheSir ToucheSir added enhancement New feature or request good first issue Good for newcomers up for grabs anyone is welcome to contribute with a PR to fix the issue labels Apr 20, 2022
@cossio
Copy link
Contributor

cossio commented May 5, 2022

The idea is to eventually deprecate @adjoint?

Or to make @adjoint fallback to rrule?

@ToucheSir
Copy link
Member Author

The former. I don't believe there is anything @adjoint can do that rrule(::ZygoteRuleConfig, ...) can't.

Or to make @adjoint fallback to rrule?

Zygote already does this. The order is @adjoint -> rrule -> AD.

@CarloLucibello
Copy link
Member

Maybe the question was if @adjoint should produce an rrule? Doesn't seem worth doing in any case

@ToucheSir ToucheSir mentioned this issue May 19, 2022
Closed
@mcabbott mcabbott added the ChainRules adjoint -> rrule, and further integration label Jul 4, 2022
@mzgubic mzgubic mentioned this issue Jul 28, 2022
Merged
@CarloLucibello CarloLucibello added this to the v0.7.0 milestone Nov 15, 2022
@CarloLucibello CarloLucibello mentioned this issue Nov 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ChainRules adjoint -> rrule, and further integration enhancement New feature or request good first issue Good for newcomers up for grabs anyone is welcome to contribute with a PR to fix the issue
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
4 participants
@ToucheSir @CarloLucibello @cossio @mcabbott