From 92bc1a0bab74778de08eaf8e7780d4f040231e59 Mon Sep 17 00:00:00 2001 From: Lyndon White Date: Tue, 17 Nov 2020 18:42:46 +0000 Subject: [PATCH 1/3] delete Matric Vector multiply rules that are now in ChainRules --- Project.toml | 2 +- src/lib/array.jl | 15 --------------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/Project.toml b/Project.toml index 0cc0fb480..f1db28b14 100644 --- a/Project.toml +++ b/Project.toml @@ -26,7 +26,7 @@ ZygoteRules = "700de1a5-db45-46bc-99cf-38207098b444" [compat] AbstractFFTs = "0.5" ArrayLayouts = "0.1, 0.2, 0.3, 0.4" -ChainRules = "0.7.16" +ChainRules = "0.7.33" DiffRules = "1.0" FillArrays = "0.8, 0.9, 0.10" ForwardDiff = "0.10" diff --git a/src/lib/array.jl b/src/lib/array.jl index 9473bc4be..a9208c76d 100644 --- a/src/lib/array.jl +++ b/src/lib/array.jl @@ -317,21 +317,6 @@ end # LinAlg # ====== -# TODO: remove these once https://github.com/JuliaDiff/ChainRules.jl/pull/305 is merged -@adjoint function(A::AbstractMatrix * x::AbstractVector) - return A * x, Δ::AbstractVector->(Δ * x', A' * Δ) -end - -@adjoint function *(x::Union{Transpose{<:Any, <:AbstractVector}, - LinearAlgebra.Adjoint{<:Any, <:AbstractVector}}, - y::AbstractVector) - return x * y, Δ->(Δ * y', x' * Δ) -end - -@adjoint function(a::AbstractVector * x::AbstractMatrix) - return a * x, Δ::AbstractMatrix->(vec(Δ * x'), a' * Δ) -end - @adjoint function transpose(x) back(Δ) = (transpose(Δ),) back(Δ::NamedTuple{(:parent,)}) = (Δ.parent,) From 4324c0176caebec6a7e25f66cb6ebf9006ab4462 Mon Sep 17 00:00:00 2001 From: Lyndon White Date: Tue, 17 Nov 2020 18:44:14 +0000 Subject: [PATCH 2/3] correct version number back down to next release --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index f1db28b14..41c407f7d 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "Zygote" uuid = "e88e6eb3-aa80-5325-afca-941959d7151f" -version = "0.5.14" +version = "0.5.15" [deps] AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c" From cf91f434fbc675c1d20faf12970465b750c09b98 Mon Sep 17 00:00:00 2001 From: Lyndon White Date: Wed, 18 Nov 2020 21:01:04 +0000 Subject: [PATCH 3/3] trivial change to retrigger CI --- src/lib/array.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/array.jl b/src/lib/array.jl index a9208c76d..e422a2365 100644 --- a/src/lib/array.jl +++ b/src/lib/array.jl @@ -314,8 +314,8 @@ end end end -# LinAlg -# ====== +# LinearAlgebra +# ============= @adjoint function transpose(x) back(Δ) = (transpose(Δ),)