Reflect mode parameter from NNlib #53
Conversation
|
@MikeInnes Won't it make more sense to get this merged to the |
|
I think we need to also expose this parameter from the Can you also create a We'll need to implement this over both branches. If you target master, I can take care of merging into julia-0.6. |
| pad = 0, stride = 1, dilation = 1, flipkernel=true) where T = | ||
| conv2d!(y, x, w, padding = pad, stride = stride, dilation = dilation, flipkernel=flipkernel) | ||
|
|
||
| crosscor!(y::AbstractArray{T,4}, x::AbstractArray{T,4}, w::AbstractArray{T,4}; |
There was a problem hiding this comment.
Cross correlation should have flipkernel=false, or at least be different from conv!, no? I also think it'd be better to keep this generic to AbstractArrays and just forward whatever the arguments are to conv!.
| x, w, pad = pad_, stride = stride_, dilation = dilation) | ||
| x, w, pad = pad_, stride = stride_, dilation = dilation, flipkernel=flipkernel) | ||
| else | ||
| crosscor!(similar(x, cdims(size(x), dilation_dims(w, dilation), pad_, stride_)), |
There was a problem hiding this comment.
It doesn't make sense to do an if/else here; you pass flipkernel through so removing it would behave the same way.
It would however be good to have an out-of-place crosscor function that calls crosscor!.
src/conv.jl
Outdated
| @@ -91,7 +101,7 @@ function dcdims(x::NTuple{4,Int}, w::NTuple{4,Int}, pad, stride) | |||
| ((x[1] + 2 * pad[1] - w[1])÷stride[1] + 1,(x[2] + 2 * pad[2] - w[2])÷stride[2] + 1,w[3]*w[4],x[4]) | |||
| end | |||
|
|
|||
| function depthwiseconv(x::A, w::A; pad = 0, stride = 1, flipkernel = true) where A<:AbstractArray | |||
| function depthwiseconv(x::A, w::A; pad = 0, stride = 1, flipkernel = false) where A<:AbstractArray | |||
There was a problem hiding this comment.
Why is flipkernel false by default for depthwise conv, but true for conv?
|
@avik-pal Ping me if you need this finished. (I'll probably open a new fresh PR) |
|
Superseded by #94 |
save allocs during algorithm search
save allocs during algorithm search
Added
modeparameter in the external functions (src/conv.jl), (option to choose cross-correlation or convolution), which were usingmode = 0by default.I will create a corresponding PR in Flux too, to adapt to the changes made in this PR.