Reconstruct with all fieldnames #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that important, non-fmappable properties with non-default values are preserved.
|
I guess the sentence "For a discussion regarding implementing functors for which only a subset of the fields are "seen" by functor, see here." could be removed from the README and replaced with an example. |
|
Seems sensible at a first glance. Thanks! |
ToucheSir
force-pushed
the
re-all-fields
branch
2 times, most recently
from
ec590af
to
c911f53
Compare
ToucheSir
force-pushed
the
re-all-fields
branch
from
c911f53
to
17487ff
Compare
|
Updated docs per @devmotion's comment. @DhairyaLGandhi can we cut a release with this so that Flux can start using it? I've seen a fair few PRs lately that stand to benefit. |
4 tasks
|
@DhairyaLGandhi bump |
|
Seems alright. This would make a breaking release though. |
|
tag? |
|
Yup, I was thinking a 0.2 so as to make it in time for Flux 0.12 (or barring that, 0.13) |
|
Cool, good that we're in agreement then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that important, non-fmappable properties with non-default values are preserved. Should address #6 and #3 (comment).
I believe this is theoretically breaking, but a search on JuliaHub doesn't turn up any uses of the macro that specify a list of fields.