Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions node 12 => node 16 #71

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Actions node 12 => node 16 #71

merged 1 commit into from
Feb 25, 2024

Conversation

vnegi10
Copy link
Contributor

@vnegi10 vnegi10 commented Jul 30, 2023

Related to FluxML/Flux.jl#2170

PR Checklist

  • Tests are added
  • Documentation, if applicable

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (abf3e10) 84.18% compared to head (892e649) 84.18%.

❗ Current head 892e649 differs from pull request most recent head 4374daa. Consider uploading reports for the commit 4374daa to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   84.18%   84.18%           
=======================================
  Files          21       21           
  Lines        1043     1043           
=======================================
  Hits          878      878           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vnegi10
Copy link
Contributor Author

vnegi10 commented Feb 25, 2024

@ToucheSir @CarloLucibello Related issue was closed, but this PR is still open.

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think this was missed because Flux3D has historically had a completely separate and independent development team, but since nobody from there has got around to this I'll merge it now.

@ToucheSir ToucheSir merged commit c546e7e into FluxML:master Feb 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants