Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RADAM optimizer #842

Merged
merged 5 commits into from
Sep 2, 2019
Merged

Add RADAM optimizer #842

merged 5 commits into from
Sep 2, 2019

Conversation

baggepinnen
Copy link
Contributor

Closes #841

@DhairyaLGandhi
Copy link
Member

Good to add it in the tests

Also, thanks for the optimiser!

@jamesjscully
Copy link

There's also an export in the Optimize.jl file

@jamesjscully
Copy link

Also did you try the optimizer? i coded this myself tonight and came up with essentially the same code. I tried my code and yours. Both were giving some strange results

@baggepinnen
Copy link
Contributor Author

Yeah, it trains but is quite unstable..

@MikeInnes
Copy link
Member

Looks like the tests are failing.

@DhairyaLGandhi
Copy link
Member

As @jamesjscully pointed; needs an export from Optimise.jl

@baggepinnen
Copy link
Contributor Author

baggepinnen commented Aug 29, 2019 •
edited
Loading

Should be fixed now

@MikeInnes
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Aug 29, 2019
@bors @baggepinnen
Merge #842
37ef63c 
842: Add RADAM optimizer r=MikeInnes a=baggepinnen

Closes #841 

Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com>
@DhairyaLGandhi
Copy link
Member

Can we also add a news item, please?

Thanks!

@bors
Copy link
Contributor

bors bot commented Aug 29, 2019

Build failed

@baggepinnen
Copy link
Contributor Author

News entry added

@MikeInnes
Copy link
Member

Bors failure appears to be unrelated. Thanks @baggepinnen!

@MikeInnes MikeInnes merged commit 3c1ac84 into FluxML:master Sep 2, 2019
@baggepinnen baggepinnen deleted the patch-4 branch November 2, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RAdam Optimizer
4 participants
@baggepinnen @DhairyaLGandhi @jamesjscully @MikeInnes